test: replace assert.equal with assert.strictEqual

Using NodeTodo I learned of a need to swap out the .equal function with .strictEqual in a few test files. https://twitter.com/NodeTodo/status/803657321993961472https://gist.github.com/Trott/864401455d4afa2428cd4814e072bd7c additional commits squashed: .strictEqual's argument signature is actual, expected, [message]. Previously some statements were listed as expected, actual. As asked in PR i swapped them to match the correct argument signature. PR-URL: #9842 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

Author: brad-decker

test/addons/async-hello-world/test.js

@@ -4,7 +4,7 @@ var assert = require('assert');
 constbinding=require(`./build/${common.buildType}/binding`);
 
 binding(5,common.mustCall(function(err,val){
-assert.equal(null,err);
-assert.equal(10,val);
+assert.strictEqual(err,null);
+assert.strictEqual(val,10);
 process.nextTick(common.mustCall(function(){}));
 }));

test/addons/hello-world-function-export/test.js

@@ -2,5 +2,5 @@
 constcommon=require('../../common');
 varassert=require('assert');
 constbinding=require(`./build/${common.buildType}/binding`);
-assert.equal('world',binding());
+assert.strictEqual(binding(),'world');
 console.log('binding.hello() =',binding());

test/addons/hello-world/test.js

@@ -2,5 +2,5 @@
 constcommon=require('../../common');
 varassert=require('assert');
 constbinding=require(`./build/${common.buildType}/binding`);
-assert.equal('world',binding.hello());
+assert.strictEqual(binding.hello(),'world');
 console.log('binding.hello() =',binding.hello());

test/addons/load-long-path/test.js

@@ -34,4 +34,4 @@ fs.writeFileSync(addonDestinationPath, contents);
 // Attempt to load at long path destination
 varaddon=require(addonDestinationPath);
 assert.notEqual(addon,null);
-assert.equal(addon.hello(),'world');
+assert.strictEqual(addon.hello(),'world');

test/addons/stringbytes-external-exceed-max/test-stringbytes-external-at-max.js

@@ -30,4 +30,4 @@ if (!binding.ensureAllocation(2 * kStringMaxLength)){
 }
 
 constmaxString=buf.toString('latin1');
-assert.equal(maxString.length,kStringMaxLength);
+assert.strictEqual(maxString.length,kStringMaxLength);

test/addons/stringbytes-external-exceed-max/test-stringbytes-external-exceed-max-by-1-binary.js

@@ -34,9 +34,9 @@ assert.throws(function(){
 },/"toString\(\)"failed/);
 
 varmaxString=buf.toString('latin1',1);
-assert.equal(maxString.length,kStringMaxLength);
+assert.strictEqual(maxString.length,kStringMaxLength);
 // Free the memory early instead of at the end of the next assignment
 maxString=undefined;
 
 maxString=buf.toString('latin1',0,kStringMaxLength);
-assert.equal(maxString.length,kStringMaxLength);
+assert.strictEqual(maxString.length,kStringMaxLength);

test/addons/stringbytes-external-exceed-max/test-stringbytes-external-exceed-max-by-2.js

@@ -30,4 +30,4 @@ if (!binding.ensureAllocation(2 * kStringMaxLength)){
 }
 
 constmaxString=buf.toString('utf16le');
-assert.equal(maxString.length,(kStringMaxLength+2)/2);
+assert.strictEqual(maxString.length,(kStringMaxLength+2)/2);