tools: auto fix custom crypto-check eslint rule

1. Fixer for crypto-check.js 2. Extends tests PR-URL: #16647 Refs: #16636 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

Author: shobhitchittora

test/parallel/test-eslint-crypto-check.js

@@ -15,20 +15,34 @@ new RuleTester().run('crypto-check', rule,{
 'foo',
 'crypto',
 `
-if (!common.hasCrypto){
-common.skip();
-}
-require('crypto');
+ if (!common.hasCrypto){
+ common.skip("missing crypto");
+ }
+ require("crypto");
  `
 ],
 invalid: [
 {
-code: 'require("crypto")',
-errors: [{ message }]
+code: 'require("common")\n'+
+'require("crypto")',
+errors: [{ message }],
+output: 'require("common")\n'+
+'if (!common.hasCrypto){'+
+' common.skip("missing crypto");'+
+'}\n'+
+'require("crypto")'
 },
 {
-code: 'if (common.foo){} require("crypto")',
-errors: [{ message }]
+code: 'require("common")\n'+
+'if (common.foo){}\n'+
+'require("crypto")',
+errors: [{ message }],
+output: 'require("common")\n'+
+'if (!common.hasCrypto){'+
+' common.skip("missing crypto");'+
+'}\n'+
+'if (common.foo){}\n'+
+'require("crypto")'
 }
 ]
 });

tools/eslint-rules/crypto-check.js

@@ -23,13 +23,18 @@ const bindingModules = cryptoModules.concat(['tls_wrap']);
 module.exports=function(context){
 constmissingCheckNodes=[];
 constrequireNodes=[];
+varcommonModuleNode=null;
 varhasSkipCall=false;
 
 functiontestCryptoUsage(node){
 if(utils.isRequired(node,requireModules)||
 utils.isBinding(node,bindingModules)){
 requireNodes.push(node);
 }
+
+if(utils.isCommonModule(node)){
+commonModuleNode=node;
+}
 }
 
 functiontestIfStatement(node){
@@ -75,7 +80,20 @@ module.exports = function(context){
 
 functionreport(nodes){
 nodes.forEach((node)=>{
-context.report(node,msg);
+context.report({
+ node,
+message: msg,
+fix: (fixer)=>{
+if(commonModuleNode){
+returnfixer.insertTextAfter(
+commonModuleNode,
+'\nif (!common.hasCrypto){'+
+' common.skip("missing crypto");'+
+'}'
+);
+}
+}
+});
 });
 }
 

tools/eslint-rules/rules-utils.js

@@ -12,6 +12,17 @@ module.exports.isRequired = function(node, modules){
 modules.includes(node.arguments[0].value);
 };
 
+/**
+* Return true if common module is required
+* in AST Node under inspection
+*/
+varcommonModuleRegExp=newRegExp(/^(\.\.\/)*common(\.js)?$/);
+module.exports.isCommonModule=function(node){
+returnnode.callee.name==='require'&&
+node.arguments.length!==0&&
+commonModuleRegExp.test(node.arguments[0].value);
+};
+
 /**
  * Returns true if any of the passed in modules are used in
  * binding calls.