test: remove common.rootDir

The three tests that use common.rootDir do not need the root dir. They just need an arbitrary directory that will exist. Use tmpdir.path instead. PR-URL: #34772 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>

Author: Trott

test/common/README.md

@@ -368,12 +368,6 @@ const{spawn } = require('child_process');
 spawn(...common.pwdCommand,{stdio: ['pipe'] });
 ```
 
-### `rootDir`
-
-*[<string>][]
-
-Path to the 'root' directory. either `/` or `c:\\` (windows)
-
 ### `runWithInvalidFD(func)`
 
 *`func`[<Function>][]

test/common/index.js

@@ -114,8 +114,6 @@ const isOSX = process.platform === 'darwin'
 
 constisDumbTerminal=process.env.TERM==='dumb';
 
-constrootDir=isWindows ? 'c:\\' : '/';
-
 constbuildType=process.config.target_defaults ?
 process.config.target_defaults.default_configuration :
 'Release';
@@ -723,7 +721,6 @@ const common ={
  platformTimeout,
  printSkipMessage,
  pwdCommand,
- rootDir,
  runWithInvalidFD,
  skip,
  skipIf32Bits,

test/common/index.mjs

@@ -19,7 +19,6 @@ const{
  isOSX,
  enoughTestMem,
  enoughTestCpu,
- rootDir,
  buildType,
  localIPv6Hosts,
  opensslCli,
@@ -66,7 +65,6 @@ export{
 isOSX,
 enoughTestMem,
 enoughTestCpu,
-rootDir,
 buildType,
 localIPv6Hosts,
 opensslCli,

test/parallel/test-child-process-cwd.js

@@ -21,6 +21,9 @@
 
 'use strict';
 constcommon=require('../common');
+consttmpdir=require('../common/tmpdir');
+tmpdir.refresh();
+
 constassert=require('assert');
 const{ spawn }=require('child_process');
 
@@ -63,7 +66,7 @@ function testCwd(options, expectCode = 0, expectData){
 }
 
 // Assume these exist, and 'pwd' gives us the right directory back
-testCwd({cwd: common.rootDir},0,common.rootDir);
+testCwd({cwd: tmpdir.path},0,tmpdir.path);
 constshouldExistDir=common.isWindows ? process.env.windir : '/dev';
 testCwd({cwd: shouldExistDir},0,shouldExistDir);
 

test/parallel/test-child-process-spawnsync.js

@@ -21,6 +21,9 @@
 
 'use strict';
 constcommon=require('../common');
+consttmpdir=require('../common/tmpdir');
+tmpdir.refresh();
+
 constassert=require('assert');
 const{ spawnSync }=require('child_process');
 const{ getSystemErrorName }=require('util');
@@ -41,7 +44,7 @@ assert.deepStrictEqual(ret_err.spawnargs, ['bar']);
 
 {
 // Test the cwd option
-constcwd=common.rootDir;
+constcwd=tmpdir.path;
 constresponse=spawnSync(...common.pwdCommand,{ cwd });
 
 assert.strictEqual(response.stdout.toString().trim(),cwd);

test/sequential/test-child-process-execsync.js

@@ -21,6 +21,9 @@
 
 'use strict';
 constcommon=require('../common');
+consttmpdir=require('../common/tmpdir');
+tmpdir.refresh();
+
 constassert=require('assert');
 
 const{ execFileSync, execSync, spawnSync }=require('child_process');
@@ -99,7 +102,7 @@ const args = [
 // Verify that the cwd option works.
 // See https://github.com/nodejs/node-v0.x-archive/issues/7824.
 {
-constcwd=common.rootDir;
+constcwd=tmpdir.path;
 constcmd=common.isWindows ? 'echo %cd%' : 'pwd';
 constresponse=execSync(cmd,{ cwd });