test: fix flaky test-dns and test-dns-lookup

Ubuntu 16.04 is going to be unsupported after April 2021. Switching Node.js CI to Ubuntu 18.04 for the internet tests resulted in failures in test-dns and test-dns-lookup because it returns server failure/try again on .invalid domain. Add a hostname for testing that will return record not found. PR-URL: #38282 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>

Author: Trott

test/common/internet.js

@@ -22,6 +22,9 @@ const addresses ={
 INVALID_HOST: 'something.invalid',
 // A host with MX records registered
 MX_HOST: 'nodejs.org',
+// On some systems, .invalid returns a server failure/try again rather than
+// record not found. Use this to guarantee record not found.
+NOT_FOUND: 'come.on.fhqwhgads',
 // A host with SRV records registered
 SRV_HOST: '_jabber._tcp.google.com',
 // A host with PTR records registered

test/internet/test-dns-lookup.js

@@ -8,39 +8,39 @@ const{addresses } = require('../common/internet');
 constassert=require('assert');
 
 assert.rejects(
-dnsPromises.lookup(addresses.INVALID_HOST,{
+dnsPromises.lookup(addresses.NOT_FOUND,{
 hints: 0,
 family: 0,
 all: false
 }),
 {
 code: 'ENOTFOUND',
-message: `getaddrinfo ENOTFOUND ${addresses.INVALID_HOST}`
+message: `getaddrinfo ENOTFOUND ${addresses.NOT_FOUND}`
 }
 );
 
 assert.rejects(
-dnsPromises.lookup(addresses.INVALID_HOST,{
+dnsPromises.lookup(addresses.NOT_FOUND,{
 hints: 0,
 family: 0,
 all: true
 }),
 {
 code: 'ENOTFOUND',
-message: `getaddrinfo ENOTFOUND ${addresses.INVALID_HOST}`
+message: `getaddrinfo ENOTFOUND ${addresses.NOT_FOUND}`
 }
 );
 
-dns.lookup(addresses.INVALID_HOST,{
+dns.lookup(addresses.NOT_FOUND,{
 hints: 0,
 family: 0,
 all: true
 },common.mustCall((error)=>{
 assert.strictEqual(error.code,'ENOTFOUND');
 assert.strictEqual(
 error.message,
-`getaddrinfo ENOTFOUND ${addresses.INVALID_HOST}`
+`getaddrinfo ENOTFOUND ${addresses.NOT_FOUND}`
 );
 assert.strictEqual(error.syscall,'getaddrinfo');
-assert.strictEqual(error.hostname,addresses.INVALID_HOST);
+assert.strictEqual(error.hostname,addresses.NOT_FOUND);
 }));

test/internet/test-dns.js

@@ -163,13 +163,13 @@ TEST(async function test_resolveMx(done){
 });
 
 TEST(functiontest_resolveMx_failure(done){
-dnsPromises.resolveMx(addresses.INVALID_HOST)
+dnsPromises.resolveMx(addresses.NOT_FOUND)
 .then(common.mustNotCall())
 .catch(common.mustCall((err)=>{
 assert.strictEqual(err.code,'ENOTFOUND');
 }));
 
-constreq=dns.resolveMx(addresses.INVALID_HOST,function(err,result){
+constreq=dns.resolveMx(addresses.NOT_FOUND,function(err,result){
 assert.ok(errinstanceofError);
 assert.strictEqual(err.code,'ENOTFOUND');
 
@@ -203,13 +203,13 @@ TEST(async function test_resolveNs(done){
 });
 
 TEST(functiontest_resolveNs_failure(done){
-dnsPromises.resolveNs(addresses.INVALID_HOST)
+dnsPromises.resolveNs(addresses.NOT_FOUND)
 .then(common.mustNotCall())
 .catch(common.mustCall((err)=>{
 assert.strictEqual(err.code,'ENOTFOUND');
 }));
 
-constreq=dns.resolveNs(addresses.INVALID_HOST,function(err,result){
+constreq=dns.resolveNs(addresses.NOT_FOUND,function(err,result){
 assert.ok(errinstanceofError);
 assert.strictEqual(err.code,'ENOTFOUND');
 
@@ -247,13 +247,13 @@ TEST(async function test_resolveSrv(done){
 });
 
 TEST(functiontest_resolveSrv_failure(done){
-dnsPromises.resolveSrv(addresses.INVALID_HOST)
+dnsPromises.resolveSrv(addresses.NOT_FOUND)
 .then(common.mustNotCall())
 .catch(common.mustCall((err)=>{
 assert.strictEqual(err.code,'ENOTFOUND');
 }));
 
-constreq=dns.resolveSrv(addresses.INVALID_HOST,function(err,result){
+constreq=dns.resolveSrv(addresses.NOT_FOUND,function(err,result){
 assert.ok(errinstanceofError);
 assert.strictEqual(err.code,'ENOTFOUND');
 
@@ -287,13 +287,13 @@ TEST(async function test_resolvePtr(done){
 });
 
 TEST(functiontest_resolvePtr_failure(done){
-dnsPromises.resolvePtr(addresses.INVALID_HOST)
+dnsPromises.resolvePtr(addresses.NOT_FOUND)
 .then(common.mustNotCall())
 .catch(common.mustCall((err)=>{
 assert.strictEqual(err.code,'ENOTFOUND');
 }));
 
-constreq=dns.resolvePtr(addresses.INVALID_HOST,function(err,result){
+constreq=dns.resolvePtr(addresses.NOT_FOUND,function(err,result){
 assert.ok(errinstanceofError);
 assert.strictEqual(err.code,'ENOTFOUND');
 
@@ -332,13 +332,13 @@ TEST(async function test_resolveNaptr(done){
 });
 
 TEST(functiontest_resolveNaptr_failure(done){
-dnsPromises.resolveNaptr(addresses.INVALID_HOST)
+dnsPromises.resolveNaptr(addresses.NOT_FOUND)
 .then(common.mustNotCall())
 .catch(common.mustCall((err)=>{
 assert.strictEqual(err.code,'ENOTFOUND');
 }));
 
-constreq=dns.resolveNaptr(addresses.INVALID_HOST,function(err,result){
+constreq=dns.resolveNaptr(addresses.NOT_FOUND,function(err,result){
 assert.ok(errinstanceofError);
 assert.strictEqual(err.code,'ENOTFOUND');
 
@@ -381,13 +381,13 @@ TEST(async function test_resolveSoa(done){
 });
 
 TEST(functiontest_resolveSoa_failure(done){
-dnsPromises.resolveSoa(addresses.INVALID_HOST)
+dnsPromises.resolveSoa(addresses.NOT_FOUND)
 .then(common.mustNotCall())
 .catch(common.mustCall((err)=>{
 assert.strictEqual(err.code,'ENOTFOUND');
 }));
 
-constreq=dns.resolveSoa(addresses.INVALID_HOST,function(err,result){
+constreq=dns.resolveSoa(addresses.NOT_FOUND,function(err,result){
 assert.ok(errinstanceofError);
 assert.strictEqual(err.code,'ENOTFOUND');
 
@@ -421,13 +421,13 @@ TEST(async function test_resolveCaa(done){
 });
 
 TEST(functiontest_resolveCaa_failure(done){
-dnsPromises.resolveTxt(addresses.INVALID_HOST)
+dnsPromises.resolveTxt(addresses.NOT_FOUND)
 .then(common.mustNotCall())
 .catch(common.mustCall((err)=>{
 assert.strictEqual(err.code,'ENOTFOUND');
 }));
 
-constreq=dns.resolveCaa(addresses.INVALID_HOST,function(err,result){
+constreq=dns.resolveCaa(addresses.NOT_FOUND,function(err,result){
 assert.ok(errinstanceofError);
 assert.strictEqual(err.code,'ENOTFOUND');
 
@@ -461,13 +461,13 @@ TEST(async function test_resolveCname(done){
 });
 
 TEST(functiontest_resolveCname_failure(done){
-dnsPromises.resolveCname(addresses.INVALID_HOST)
+dnsPromises.resolveCname(addresses.NOT_FOUND)
 .then(common.mustNotCall())
 .catch(common.mustCall((err)=>{
 assert.strictEqual(err.code,'ENOTFOUND');
 }));
 
-constreq=dns.resolveCname(addresses.INVALID_HOST,function(err,result){
+constreq=dns.resolveCname(addresses.NOT_FOUND,function(err,result){
 assert.ok(errinstanceofError);
 assert.strictEqual(err.code,'ENOTFOUND');
 
@@ -499,13 +499,13 @@ TEST(async function test_resolveTxt(done){
 });
 
 TEST(functiontest_resolveTxt_failure(done){
-dnsPromises.resolveTxt(addresses.INVALID_HOST)
+dnsPromises.resolveTxt(addresses.NOT_FOUND)
 .then(common.mustNotCall())
 .catch(common.mustCall((err)=>{
 assert.strictEqual(err.code,'ENOTFOUND');
 }));
 
-constreq=dns.resolveTxt(addresses.INVALID_HOST,function(err,result){
+constreq=dns.resolveTxt(addresses.NOT_FOUND,function(err,result){
 assert.ok(errinstanceofError);
 assert.strictEqual(err.code,'ENOTFOUND');
 
@@ -519,16 +519,16 @@ TEST(function test_resolveTxt_failure(done){
 
 
 TEST(functiontest_lookup_failure(done){
-dnsPromises.lookup(addresses.INVALID_HOST,4)
+dnsPromises.lookup(addresses.NOT_FOUND,4)
 .then(common.mustNotCall())
 .catch(common.expectsError({code: dns.NOTFOUND}));
 
-constreq=dns.lookup(addresses.INVALID_HOST,4,(err)=>{
+constreq=dns.lookup(addresses.NOT_FOUND,4,(err)=>{
 assert.ok(errinstanceofError);
 assert.strictEqual(err.code,dns.NOTFOUND);
 assert.strictEqual(err.code,'ENOTFOUND');
 assert.ok(!/ENOENT/.test(err.message));
-assert.ok(err.message.includes(addresses.INVALID_HOST));
+assert.ok(err.message.includes(addresses.NOT_FOUND));
 
 done();
 });
@@ -672,18 +672,18 @@ TEST(function test_reverse_failure(done){
 
 
 TEST(functiontest_lookup_failure(done){
-dnsPromises.lookup(addresses.INVALID_HOST)
+dnsPromises.lookup(addresses.NOT_FOUND)
 .then(common.mustNotCall())
 .catch(common.expectsError({
 code: 'ENOTFOUND',
-hostname: addresses.INVALID_HOST
+hostname: addresses.NOT_FOUND
 }));
 
-constreq=dns.lookup(addresses.INVALID_HOST,(err)=>{
+constreq=dns.lookup(addresses.NOT_FOUND,(err)=>{
 assert(errinstanceofError);
 assert.strictEqual(err.code,'ENOTFOUND');// Silly error code...
-assert.strictEqual(err.hostname,addresses.INVALID_HOST);
-assert.ok(err.message.includes(addresses.INVALID_HOST));
+assert.strictEqual(err.hostname,addresses.NOT_FOUND);
+assert.ok(err.message.includes(addresses.NOT_FOUND));
 
 done();
 });
@@ -693,7 +693,7 @@ TEST(function test_lookup_failure(done){
 
 
 TEST(functiontest_resolve_failure(done){
-constreq=dns.resolve4(addresses.INVALID_HOST,(err)=>{
+constreq=dns.resolve4(addresses.NOT_FOUND,(err)=>{
 assert(errinstanceofError);
 
 switch(err.code){
@@ -705,8 +705,8 @@ TEST(function test_resolve_failure(done){
 break;
 }
 
-assert.strictEqual(err.hostname,addresses.INVALID_HOST);
-assert.ok(err.message.includes(addresses.INVALID_HOST));
+assert.strictEqual(err.hostname,addresses.NOT_FOUND);
+assert.ok(err.message.includes(addresses.NOT_FOUND));
 
 done();
 });