cluster: use Map to track handles in master

PR-URL: #23125 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Denys Otrishko <[email protected]>

Author: cjihrig

lib/internal/cluster/master.js

@@ -148,20 +148,18 @@ function removeWorker(worker){
 deletecluster.workers[worker.id];
 
 if(keys(cluster.workers).length===0){
-assert(keys(handles).length===0,'Resource leak detected.');
+assert(handles.size===0,'Resource leak detected.');
 intercom.emit('disconnect');
 }
 }
 
 functionremoveHandlesForWorker(worker){
 assert(worker);
 
-for(varkeyinhandles){
-consthandle=handles[key];
-
+handles.forEach((handle,key)=>{
 if(handle.remove(worker))
-deletehandles[key];
-}
+handles.delete(key);
+});
 }
 
 cluster.fork=function(env){
@@ -277,7 +275,7 @@ function queryServer(worker, message){
 
 constkey=`${message.address}:${message.port}:${message.addressType}:`+
 `${message.fd}:${message.index}`;
-varhandle=handles[key];
+varhandle=handles.get(key);
 
 if(handle===undefined){
 letaddress=message.address;
@@ -302,12 +300,13 @@ function queryServer(worker, message){
 constructor=SharedHandle;
 }
 
-handles[key]=handle=newconstructor(key,
-address,
-message.port,
-message.addressType,
-message.fd,
-message.flags);
+handle=newconstructor(key,
+address,
+message.port,
+message.addressType,
+message.fd,
+message.flags);
+handles.set(key,handle);
 }
 
 if(!handle.data)
@@ -319,11 +318,11 @@ function queryServer(worker, message){
 errno: errno,
 key: key,
 ack: message.seq,
-data: handles[key].data
+data: handles.get(key).data
 },reply);
 
 if(errno)
-deletehandles[key];// Gives other workers a chance to retry.
+handles.delete(key);// Gives other workers a chance to retry.
 
 send(worker,reply,handle);
 });
@@ -346,10 +345,10 @@ function listening(worker, message){
 // removed by a prior call to removeHandlesForWorker() so guard against that.
 functionclose(worker,message){
 constkey=message.key;
-consthandle=handles[key];
+consthandle=handles.get(key);
 
 if(handle&&handle.remove(worker))
-deletehandles[key];
+handles.delete(key);
 }
 
 functionsend(worker,message,handle,cb){

lib/internal/cluster/utils.js

@@ -4,7 +4,7 @@ const util = require('util');
 module.exports={
  sendHelper,
  internal,
-handles: {}// Used in tests.
+handles: newMap()// Used in tests.
 };
 
 constcallbacks=newMap();