doc: enable eslint prefer-template rule

BridgeAR · MylesBorins · commit cb732aeda47f · 2018-03-21T10:50:20.000Z
Backport-PR-URL: #19244 PR-URL: #18831 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matheus Marchini <matheus@sthima.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
diff --git a/doc/.eslintrc.yaml b/doc/.eslintrc.yaml
@@ -12,6 +12,7 @@ rules:
 no-var: error
 prefer-const: error
 prefer-rest-params: error
+ prefer-template: error
 
 # Stylistic Issues
 no-multiple-empty-lines: [error,{max: 1, maxEOF: 0, maxBOF: 0}]
diff --git a/doc/api/esm.md b/doc/api/esm.md
@@ -114,7 +114,7 @@ given module specifier and parent file URL:
 
 ```js
 const baseURL = new URL('file://');
-baseURL.pathname = process.cwd() + '/';
+baseURL.pathname = `${process.cwd()}/`;
 
 export async function resolve(specifier,
 parentModuleURL = baseURL,
@@ -158,7 +158,7 @@ const builtins = Module.builtinModules;
 const JS_EXTENSIONS = new Set(['.js', '.mjs']);
 
 const baseURL = new URL('file://');
-baseURL.pathname = process.cwd() + '/';
+baseURL.pathname = `${process.cwd()}/`;
 
 export function resolve(specifier, parentModuleURL = baseURL, defaultResolve){
 if (builtins.includes(specifier)){
diff --git a/doc/api/stream.md b/doc/api/stream.md
@@ -1801,7 +1801,7 @@ class Counter extends Readable{
 if (i > this._max)
 this.push(null);
 else{
- const str = '' + i;
+ const str = String(i);
 const buf = Buffer.from(str, 'ascii');
 this.push(buf);
 }

-Original file line number
+Diff line change
 ```js
 constbaseURL=newURL('file://');
 -baseURL.pathname=process.cwd()+'/';
 +baseURL.pathname=`${process.cwd()}/`;
 exportasyncfunctionresolve(specifier,
 parentModuleURL=baseURL,
 constJS_EXTENSIONS=newSet(['.js', '.mjs']);
 constbaseURL=newURL('file://');
 -baseURL.pathname=process.cwd()+'/';
 +baseURL.pathname=`${process.cwd()}/`;
 exportfunctionresolve(specifier, parentModuleURL=baseURL, defaultResolve){
 if (builtins.includes(specifier)){
Original file line number	Diff line number	Diff line change
`@@ -1801,7 +1801,7 @@ class Counter extends Readable{`
`1801`	`1801`	`if (i >this._max)`
`1802`	`1802`	`this.push(null);`
`1803`	`1803`	`else{`
`1804`		`-conststr=''+ i;`
	`1804`	`+conststr=String(i);`
`1805`	`1805`	`constbuf=Buffer.from(str, 'ascii');`
`1806`	`1806`	`this.push(buf);`
`1807`	`1807`	`}`