assert,crypto: make KeyObject and CryptoKey testable for equality

PR-URL: #50897 Reviewed-By: Antoine du Hamel <[email protected]>

Author: panva

lib/internal/util/comparisons.js

@@ -44,6 +44,8 @@ const{
  isSymbolObject,
  isFloat32Array,
  isFloat64Array,
+ isKeyObject,
+ isCryptoKey,
 }=types;
 const{
 constants: {
@@ -61,6 +63,8 @@ const kIsArray = 1;
 constkIsSet=2;
 constkIsMap=3;
 
+letkKeyObject;
+
 // Check if they have the same source and flags
 functionareSimilarRegExps(a,b){
 returna.source===b.source&&
@@ -251,6 +255,20 @@ function innerDeepEqual(val1, val2, strict, memos){
 isNativeError(val2)||
 val2instanceofError){
 returnfalse;
+}elseif(isKeyObject(val1)){
+if(!isKeyObject(val2)||!val1.equals(val2)){
+returnfalse;
+}
+}elseif(isCryptoKey(val1)){
+kKeyObject??=require('internal/crypto/util').kKeyObject;
+if(!isCryptoKey(val2)||
+val1.extractable!==val2.extractable||
+!innerDeepEqual(val1.algorithm,val2.algorithm,strict,memos)||
+!innerDeepEqual(val1.usages,val2.usages,strict,memos)||
+!innerDeepEqual(val1[kKeyObject],val2[kKeyObject],strict,memos)
+){
+returnfalse;
+}
 }
 returnkeyCheck(val1,val2,strict,memos,kNoIterator);
 }

test/parallel/test-assert-deep.js

@@ -1,6 +1,6 @@
 'use strict';
 
-require('../common');
+constcommon=require('../common');
 constassert=require('assert');
 constutil=require('util');
 const{ AssertionError }=assert;
@@ -1220,3 +1220,60 @@ assert.throws(
 
 assertNotDeepOrStrict(a,b);
 }
+
+// eslint-disable-next-line node-core/crypto-check
+if(common.hasCrypto){
+constcrypto=require('crypto');
+const{ subtle }=globalThis.crypto;
+
+{
+consta=crypto.createSecretKey(Buffer.alloc(1,0));
+constb=crypto.createSecretKey(Buffer.alloc(1,1));
+
+assertNotDeepOrStrict(a,b);
+}
+
+{
+consta=crypto.createSecretKey(Buffer.alloc(0));
+constb=crypto.createSecretKey(Buffer.alloc(0));
+
+assertDeepAndStrictEqual(a,b);
+}
+
+(async()=>{
+{
+consta=awaitsubtle.importKey('raw',Buffer.alloc(1,0),{name: 'HMAC',hash: 'SHA-256'},true,['sign']);
+constb=awaitsubtle.importKey('raw',Buffer.alloc(1,1),{name: 'HMAC',hash: 'SHA-256'},true,['sign']);
+
+assertNotDeepOrStrict(a,b);
+}
+
+{
+consta=awaitsubtle.importKey('raw',Buffer.alloc(1),{name: 'HMAC',hash: 'SHA-256'},true,['sign']);
+constb=awaitsubtle.importKey('raw',Buffer.alloc(1),{name: 'HMAC',hash: 'SHA-256'},false,['sign']);
+
+assertNotDeepOrStrict(a,b);
+}
+
+{
+consta=awaitsubtle.importKey('raw',Buffer.alloc(1),{name: 'HMAC',hash: 'SHA-256'},true,['sign']);
+constb=awaitsubtle.importKey('raw',Buffer.alloc(1),{name: 'HMAC',hash: 'SHA-384'},true,['sign']);
+
+assertNotDeepOrStrict(a,b);
+}
+
+{
+consta=awaitsubtle.importKey('raw',Buffer.alloc(1),{name: 'HMAC',hash: 'SHA-256'},true,['sign']);
+constb=awaitsubtle.importKey('raw',Buffer.alloc(1),{name: 'HMAC',hash: 'SHA-256'},true,['verify']);
+
+assertNotDeepOrStrict(a,b);
+}
+
+{
+consta=awaitsubtle.importKey('raw',Buffer.alloc(1),{name: 'HMAC',hash: 'SHA-256'},true,['sign']);
+constb=awaitsubtle.importKey('raw',Buffer.alloc(1),{name: 'HMAC',hash: 'SHA-256'},true,['sign']);
+
+assertDeepAndStrictEqual(a,b);
+}
+})().then(common.mustCall());
+}