test_runner: suite fixes

Author: MoLow

lib/internal/test_runner/test.js

@@ -1,12 +1,12 @@
 'use strict';
 const{
+ ArrayPrototypeMap,
  ArrayPrototypePush,
- ArrayPrototypeReduce,
  ArrayPrototypeShift,
  ArrayPrototypeUnshift,
  FunctionPrototype,
  Number,
-PromiseResolve,
+PromiseAll,
  ReflectApply,
  SafeMap,
 }=primordials;
@@ -457,7 +457,11 @@ class Suite extends Test{
 constructor(options){
 super(options);
 
-this.runInAsyncScope(this.fn);
+try{
+this.runInAsyncScope(this.fn);
+}catch(err){
+this.fail(newERR_TEST_FAILURE(err,kTestCodeFailure));
+}
 this.fn=()=>{};
 this.finished=true;// Forbid adding subtests to this suite
 }
@@ -469,11 +473,8 @@ class Suite extends Test{
 asyncrun(){
 this.parent.activeSubtests++;
 this.startTime=hrtime();
-constsubtests=this.skipped ? [] : this.subtests;
-awaitArrayPrototypeReduce(subtests,async(prev,subtest)=>{
-awaitprev;
-awaitsubtest.run();
-},PromiseResolve());
+constsubtests=this.skipped||this.error ? [] : this.subtests;
+awaitPromiseAll(ArrayPrototypeMap(subtests,(subtests)=>subtests.start()));
 this.pass();
 this.postRun();
 }

test/message/test_runner_desctibe_it.out

@@ -182,6 +182,10 @@ ok 19 - immediate resolve pass
  *
  *
  *
+ *
+ *
+ *
+ *
  ...
  1..1
 not ok 20 - subtest sync throw fail
@@ -465,6 +469,9 @@ not ok 52 - custom inspect symbol that throws fail
  *
  *
  *
+ *
+ *
+ *
  ...
  # Subtest: sync throw fails at second
  not ok 2 - sync throw fails at second
@@ -480,6 +487,10 @@ not ok 52 - custom inspect symbol that throws fail
  *
  *
  *
+ *
+ *
+ *
+ *
  ...
  1..2
 not ok 53 - subtest sync throw fails