test: check noop function invocations

In test/pummel/test-stream2-basic.js, check that noop functions are called the expected number of times. PR-URL: #13146 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

Author: Trott

test/pummel/test-stream2-basic.js

@@ -147,7 +147,7 @@ test('a most basic test', function(t){
 'xxxxxxxxxxxxxxxxxxxxx'];
 
 r.on('end',function(){
-t.same(reads,expect);
+assert.strict(reads,expect);
 t.end();
 });
 
@@ -180,7 +180,7 @@ test('pipe', function(t){
 constw=newTestWriter();
 
 w.on('end',function(received){
-t.same(received,expect);
+assert.strict(received,expect);
 t.end();
 });
 
@@ -226,15 +226,15 @@ test('pipe', function(t){
 t.equal(ended0,false);
 ended0=true;
 ended++;
-t.same(results,expect[0]);
+assert.strict(results,expect[0]);
 });
 
 w[1].on('end',function(results){
 t.equal(ended1,false);
 ended1=true;
 ended++;
 t.equal(ended,2);
-t.same(results,expect[1]);
+assert.strict(results,expect[1]);
 t.end();
 });
 
@@ -261,11 +261,11 @@ test('multipipe', function(t){
 
 letc=2;
 w[0].on('end',function(received){
-t.same(received,expect,'first');
+assert.strict(received,expect,'first');
 if(--c===0)t.end();
 });
 w[1].on('end',function(received){
-t.same(received,expect,'second');
+assert.strict(received,expect,'second');
 if(--c===0)t.end();
 });
 
@@ -306,13 +306,13 @@ test('multipipe', function(t){
 
 w[0].on('end',function(results){
 ended++;
-t.same(results,expect[0]);
+assert.strict(results,expect[0]);
 });
 
 w[1].on('end',function(results){
 ended++;
 t.equal(ended,2);
-t.same(results,expect[1]);
+assert.strict(results,expect[1]);
 t.end();
 });
 
@@ -323,7 +323,7 @@ test('multipipe', function(t){
 
 test('back pressure respected',function(t){
 constr=newR({objectMode: true});
-r._read=common.noop;
+r._read=common.mustNotCall();
 letcounter=0;
 r.push(['one']);
 r.push(['two']);
@@ -341,7 +341,7 @@ test('back pressure respected', function(t){
 r.pipe(w3);
 });
 };
-w1.end=common.noop;
+w1.end=common.mustNotCall();
 
 r.pipe(w1);
 
@@ -367,7 +367,7 @@ test('back pressure respected', function(t){
 
 returnfalse;
 };
-w2.end=common.noop;
+w2.end=common.mustCall();
 
 constw3=newR();
 w3.write=function(chunk){
@@ -400,7 +400,7 @@ test('read(0) for ended streams', function(t){
 constr=newR();
 letwritten=false;
 letended=false;
-r._read=common.noop;
+r._read=common.mustNotCall();
 
 r.push(Buffer.from('foo'));
 r.push(null);
@@ -471,7 +471,7 @@ test('adding readable triggers data flow', function(t){
 
 test('chainable',function(t){
 constr=newR();
-r._read=common.noop;
+r._read=common.mustCall();
 constr2=r.setEncoding('utf8').pause().resume().pause();
 t.equal(r,r2);
 t.end();