test: extend env for test-node-output-errors

richardlau · web-flow · commit cd8e61fe2630 · 2024-06-23T18:53:03.000Z
Extend, rather than replace, `env` for `test-node-output-errors` so that `node` binaries that need `LD_LIBRARY_PATH`, `LIBPATH` or `DYLD_LIBRARY_PATH` can run. PR-URL: #53535 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
diff --git a/test/parallel/test-node-output-errors.mjs b/test/parallel/test-node-output-errors.mjs
@@ -6,8 +6,6 @@ import{describe, it } from 'node:test';
 import{pathToFileURL } from 'node:url';
 
 const skipForceColors =
- process.config.variables.icu_gyp_path !== 'tools/icu/icu-generic.gyp' ||
- process.config.variables.node_shared_openssl ||
 (common.isWindows && (Number(os.release().split('.')[0]) !== 10 || Number(os.release().split('.')[2]) < 14393)); // See https://github.com/nodejs/node/pull/33132
 
 
@@ -76,7 +74,7 @@ describe('errors output',{concurrency: !process.env.TEST_PARALLEL }, () =>{
 ];
 for (const{name, transform = defaultTransform, env, skip = false } of tests){
 it(name,{skip }, async () =>{
- await snapshot.spawnAndAssert(fixtures.path(name), transform,{env });
+ await snapshot.spawnAndAssert(fixtures.path(name), transform,{env:{...env, ...process.env } });
 });
 }
 });

-Original file line number
+Diff line change
 import{pathToFileURL}from'node:url';
 constskipForceColors=
 -process.config.variables.icu_gyp_path!=='tools/icu/icu-generic.gyp'||
 -process.config.variables.node_shared_openssl||
 (common.isWindows&&(Number(os.release().split('.')[0])!==10||Number(os.release().split('.')[2])<14393));// See https://github.com/nodejs/node/pull/33132
 ];
 for(const{ name, transform =defaultTransform, env, skip =false}oftests){
 it(name,{ skip },async()=>{
 -awaitsnapshot.spawnAndAssert(fixtures.path(name),transform,{ env });
 +awaitsnapshot.spawnAndAssert(fixtures.path(name),transform,{env: { ...env, ...process.env}});
 });
+}
 });