test: refactor test-tls-ocsp-callback

refactor all var to either const/let change all assert.equal to assert.strictEqual change all assert.ok(...===...) to assert.strictEqual PR-URL: #9970 Reviewed-By: Prince John Wesley <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>

Author: kathytruong

test/parallel/test-tls-ocsp-callback.js

@@ -1,5 +1,5 @@
 'use strict';
-varcommon=require('../common');
+constcommon=require('../common');
 
 if(!process.features.tls_ocsp){
 common.skip('node compiled without OpenSSL or '+
@@ -15,33 +15,33 @@ if (!common.hasCrypto){
 common.skip('missing crypto');
 return;
 }
-vartls=require('tls');
+consttls=require('tls');
 
-varassert=require('assert');
-varfs=require('fs');
-varjoin=require('path').join;
+constassert=require('assert');
+constfs=require('fs');
+constjoin=require('path').join;
 
 constSSL_OP_NO_TICKET=require('crypto').constants.SSL_OP_NO_TICKET;
 
-varpfx=fs.readFileSync(join(common.fixturesDir,'keys','agent1-pfx.pem'));
+constpfx=fs.readFileSync(join(common.fixturesDir,'keys','agent1-pfx.pem'));
 
 functiontest(testOptions,cb){
 
-varkeyFile=join(common.fixturesDir,'keys','agent1-key.pem');
-varcertFile=join(common.fixturesDir,'keys','agent1-cert.pem');
-varcaFile=join(common.fixturesDir,'keys','ca1-cert.pem');
-varkey=fs.readFileSync(keyFile);
-varcert=fs.readFileSync(certFile);
-varca=fs.readFileSync(caFile);
-varoptions={
+constkeyFile=join(common.fixturesDir,'keys','agent1-key.pem');
+constcertFile=join(common.fixturesDir,'keys','agent1-cert.pem');
+constcaFile=join(common.fixturesDir,'keys','ca1-cert.pem');
+constkey=fs.readFileSync(keyFile);
+constcert=fs.readFileSync(certFile);
+constca=fs.readFileSync(caFile);
+constoptions={
 key: key,
 cert: cert,
 ca: [ca]
 };
-varrequestCount=0;
-varclientSecure=0;
-varocspCount=0;
-varocspResponse;
+letrequestCount=0;
+letclientSecure=0;
+letocspCount=0;
+letocspResponse;
 
 if(testOptions.pfx){
 deleteoptions.key;
@@ -50,7 +50,7 @@ function test(testOptions, cb){
 options.passphrase=testOptions.passphrase;
 }
 
-varserver=tls.createServer(options,function(cleartext){
+constserver=tls.createServer(options,function(cleartext){
 cleartext.on('error',function(er){
 // We're ok with getting ECONNRESET in this test, but it's
 // timing-dependent, and thus unreliable. Any other errors
@@ -73,7 +73,7 @@ function test(testOptions, cb){
 },100);
 });
 server.listen(0,function(){
-varclient=tls.connect({
+constclient=tls.connect({
 port: this.address().port,
 requestOCSP: testOptions.ocsp!==false,
 secureOptions: testOptions.ocsp===false ?
@@ -94,23 +94,23 @@ function test(testOptions, cb){
 
 process.on('exit',function(){
 if(testOptions.ocsp===false){
-assert.equal(requestCount,clientSecure);
-assert.equal(requestCount,1);
+assert.strictEqual(requestCount,clientSecure);
+assert.strictEqual(requestCount,1);
 return;
 }
 
 if(testOptions.response){
-assert.equal(ocspResponse.toString(),testOptions.response);
+assert.strictEqual(ocspResponse.toString(),testOptions.response);
 }else{
-assert.ok(ocspResponse===null);
+assert.strictEqual(ocspResponse,null);
 }
-assert.equal(requestCount,testOptions.response ? 0 : 1);
-assert.equal(clientSecure,requestCount);
-assert.equal(ocspCount,1);
+assert.strictEqual(requestCount,testOptions.response ? 0 : 1);
+assert.strictEqual(clientSecure,requestCount);
+assert.strictEqual(ocspCount,1);
 });
 }
 
-vartests=[
+consttests=[
 {response: false},
 {response: 'hello world'},
 {ocsp: false}