perf_hooks: reduce overhead of new resource timings

Author: H4ad

benchmark/perf_hooks/resourcetiming.js

@@ -72,6 +72,6 @@ function main({n, observe }){
 obs.observe({entryTypes: [observe],buffered: true});
 
 bench.start();
-for(leti=0;i<1e5;i++)
+for(leti=0;i<n;i++)
 test();
 }

lib/internal/perf/performance_entry.js

@@ -31,10 +31,12 @@ function isPerformanceEntry(obj){
 }
 
 classPerformanceEntry{
-constructor(skipThrowSymbol=undefined){
+constructor(skipThrowSymbol=undefined,name=undefined,type=undefined,start=undefined,duration=undefined){
 if(skipThrowSymbol!==kSkipThrow){
 thrownewERR_ILLEGAL_CONSTRUCTOR();
 }
+
+initPerformanceEntry(this,name,type,start,duration);
 }
 
 getname(){
@@ -94,11 +96,7 @@ function initPerformanceEntry(entry, name, type, start, duration){
 }
 
 functioncreatePerformanceEntry(name,type,start,duration){
-constentry=newPerformanceEntry(kSkipThrow);
-
-initPerformanceEntry(entry,name,type,start,duration);
-
-returnentry;
+returnnewPerformanceEntry(kSkipThrow,name,type,start,duration);
 }
 
 /**
@@ -123,9 +121,8 @@ class PerformanceNodeEntry extends PerformanceEntry{
 }
 
 functioncreatePerformanceNodeEntry(name,type,start,duration,detail){
-constentry=newPerformanceNodeEntry(kSkipThrow);
+constentry=newPerformanceNodeEntry(kSkipThrow,name,type,start,duration);
 
-initPerformanceEntry(entry,name,type,start,duration);
 entry[kDetail]=detail;
 
 returnentry;
@@ -138,4 +135,5 @@ module.exports ={
  isPerformanceEntry,
  PerformanceNodeEntry,
  createPerformanceNodeEntry,
+ kSkipThrow,
 };

lib/internal/perf/resource_timing.js

@@ -3,19 +3,17 @@
 
 const{
  ObjectDefineProperties,
- ObjectSetPrototypeOf,
- ReflectConstruct,
  Symbol,
  SymbolToStringTag,
 }=primordials;
-const{ initPerformanceEntry, PerformanceEntry }=require('internal/perf/performance_entry');
-constassert=require('internal/assert');
-const{ enqueue, bufferResourceTiming }=require('internal/perf/observe');
 const{
 codes: {
 ERR_ILLEGAL_CONSTRUCTOR,
 },
 }=require('internal/errors');
+const{ PerformanceEntry, kSkipThrow }=require('internal/perf/performance_entry');
+constassert=require('internal/assert');
+const{ enqueue, bufferResourceTiming }=require('internal/perf/observe');
 const{ validateInternalField }=require('internal/validators');
 const{ kEnumerableProperty }=require('internal/util');
 
@@ -25,8 +23,12 @@ const kTimingInfo = Symbol('kTimingInfo');
 constkInitiatorType=Symbol('kInitiatorType');
 
 classPerformanceResourceTimingextendsPerformanceEntry{
-constructor(){
-thrownewERR_ILLEGAL_CONSTRUCTOR();
+constructor(skipThrowSymbol=undefined,name=undefined,type=undefined){
+if(skipThrowSymbol!==kSkipThrow){
+thrownewERR_ILLEGAL_CONSTRUCTOR();
+}
+
+super(skipThrowSymbol,name,type);
 }
 
 getname(){
@@ -189,16 +191,17 @@ ObjectDefineProperties(PerformanceResourceTiming.prototype,{
 });
 
 functioncreatePerformanceResourceTiming(requestedUrl,initiatorType,timingInfo,cacheMode=''){
-returnReflectConstruct(functionPerformanceResourceTiming(){
-initPerformanceEntry(this,requestedUrl,'resource');
-this[kInitiatorType]=initiatorType;
-this[kRequestedUrl]=requestedUrl;
-// https://fetch.spec.whatwg.org/#fetch-timing-info
-// This class is using timingInfo assuming it's already validated.
-// The spec doesn't say to validate it in the class construction.
-this[kTimingInfo]=timingInfo;
-this[kCacheMode]=cacheMode;
-},[],PerformanceResourceTiming);
+constresourceTiming=newPerformanceResourceTiming(kSkipThrow,requestedUrl,'resource');
+
+resourceTiming[kInitiatorType]=initiatorType;
+resourceTiming[kRequestedUrl]=requestedUrl;
+// https://fetch.spec.whatwg.org/#fetch-timing-info
+// This class is using timingInfo assuming it's already validated.
+// The spec doesn't say to validate it in the class construction.
+resourceTiming[kTimingInfo]=timingInfo;
+resourceTiming[kCacheMode]=cacheMode;
+
+returnresourceTiming;
 }
 
 // https://w3c.github.io/resource-timing/#dfn-mark-resource-timing
@@ -221,7 +224,6 @@ function markResourceTiming(
 cacheMode,
 );
 
-ObjectSetPrototypeOf(resource,PerformanceResourceTiming.prototype);
 enqueue(resource);
 bufferResourceTiming(resource);
 returnresource;