http: make ClientRequest#setTimeout() noop at end

Originally discovered and resolved by @szmarczak. PR-URL: #25536Fixes: #25499 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

Author: timdp

lib/_http_client.js

@@ -727,6 +727,10 @@ function _deferToConnect(method, arguments_, cb){
 }
 
 ClientRequest.prototype.setTimeout=functionsetTimeout(msecs,callback){
+if(this._ended){
+returnthis;
+}
+
 listenSocketTimeout(this);
 msecs=validateTimerDuration(msecs);
 if(callback)this.once('timeout',callback);

test/parallel/test-http-client-set-timeout-after-end.js

@@ -0,0 +1,33 @@
+'use strict';
+
+// Test https://github.com/nodejs/node/issues/25499 fix.
+
+const{ mustCall }=require('../common');
+
+const{ Agent, createServer, get }=require('http');
+const{ strictEqual }=require('assert');
+
+constserver=createServer(mustCall((req,res)=>{
+res.end();
+}));
+
+server.listen(0,()=>{
+constagent=newAgent({keepAlive: true,maxSockets: 1});
+constport=server.address().port;
+
+letsocket;
+
+constreq=get({ agent, port },(res)=>{
+res.on('end',()=>{
+strictEqual(req.setTimeout(0),req);
+strictEqual(socket.listenerCount('timeout'),0);
+agent.destroy();
+server.close();
+});
+res.resume();
+});
+
+req.on('socket',(sock)=>{
+socket=sock;
+});
+});