test: increase abort logic coverage

shootermv · targos · commit cf8d02520753 · 2021-05-01T09:44:46.000+02:00
PR-URL: #36586 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
diff --git a/test/parallel/test-fs-promises-readfile.js b/test/parallel/test-fs-promises-readfile.js
@@ -61,10 +61,22 @@ function validateReadFileAbortLogicDuring(){
 });
 }
 
+async function validateWrongSignalParam(){
+ // Verify that if something different than Abortcontroller.signal
+ // is passed, ERR_INVALID_ARG_TYPE is thrown
+
+ await assert.rejects(async () =>{
+ const callback = common.mustNotCall(() =>{});
+ await readFile(fn,{signal: 'hello' }, callback);
+ },{code: 'ERR_INVALID_ARG_TYPE', name: 'TypeError' });
+
+}
+
 (async () =>{
 await createLargeFile();
 await validateReadFile();
 await validateReadFileProc();
 await validateReadFileAbortLogicBefore();
 await validateReadFileAbortLogicDuring();
+ await validateWrongSignalParam();
 })().then(common.mustCall());

-Original file line number
+Diff line change
 });
+}
 +asyncfunctionvalidateWrongSignalParam(){
 +// Verify that if something different than Abortcontroller.signal
 +// is passed, ERR_INVALID_ARG_TYPE is thrown
++
 +awaitassert.rejects(async()=>{
 +constcallback=common.mustNotCall(()=>{});
 +awaitreadFile(fn,{signal: 'hello'},callback);
 +},{code: 'ERR_INVALID_ARG_TYPE',name: 'TypeError'});
++
 +}
++
 (async()=>{
 awaitcreateLargeFile();
 awaitvalidateReadFile();
 awaitvalidateReadFileProc();
 awaitvalidateReadFileAbortLogicBefore();
 awaitvalidateReadFileAbortLogicDuring();
 +awaitvalidateWrongSignalParam();
 })().then(common.mustCall());