Skip to content

Commit cfe5380

Browse files
cjihrigmarco-ippolito
authored andcommitted
test: update test-set-http-max-http-headers to use node:test
This commit updates test/parallel/test-set-http-max-http-headers.js to use node:test. This test already implemented a test runner, so it makes sense to use the existing public API. PR-URL: #56439 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 51ff71a commit cfe5380

File tree

1 file changed

+8
-29
lines changed

1 file changed

+8
-29
lines changed

‎test/parallel/test-set-http-max-http-headers.js‎

Lines changed: 8 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -4,17 +4,10 @@ const common = require('../common');
44
constassert=require('assert');
55
const{ spawn }=require('child_process');
66
constpath=require('path');
7+
const{ suite, test }=require('node:test');
78
consttestName=path.join(__dirname,'test-http-max-http-headers.js');
89

9-
consttimeout=common.platformTimeout(100);
10-
11-
consttests=[];
12-
13-
functiontest(fn){
14-
tests.push(fn);
15-
}
16-
17-
test(function(cb){
10+
test(function(_,cb){
1811
console.log('running subtest expecting failure');
1912

2013
// Validate that the test fails if the max header size is too small.
@@ -30,7 +23,7 @@ test(function(cb){
3023
}));
3124
});
3225

33-
test(function(cb){
26+
test(function(_,cb){
3427
console.log('running subtest expecting success');
3528

3629
constenv=Object.assign({},process.env,{
@@ -54,13 +47,13 @@ test(function(cb){
5447
}));
5548
});
5649

57-
// Next, repeat the same checks using NODE_OPTIONS if it is supported.
58-
if(!process.config.variables.node_without_node_options){
50+
constskip=process.config.variables.node_without_node_options;
51+
suite('same checks using NODE_OPTIONS if it is supported',{ skip },()=>{
5952
constenv=Object.assign({},process.env,{
6053
NODE_OPTIONS: '--max-http-header-size=1024'
6154
});
6255

63-
test(function(cb){
56+
test(function(_,cb){
6457
console.log('running subtest expecting failure');
6558

6659
// Validate that the test fails if the max header size is too small.
@@ -74,7 +67,7 @@ if (!process.config.variables.node_without_node_options){
7467
}));
7568
});
7669

77-
test(function(cb){
70+
test(function(_,cb){
7871
// Validate that the test now passes if the same limit is large enough.
7972
constargs=['--expose-internals',testName,'1024'];
8073
constcp=spawn(process.execPath,args,{ env,stdio: 'inherit'});
@@ -85,18 +78,4 @@ if (!process.config.variables.node_without_node_options){
8578
cb();
8679
}));
8780
});
88-
}
89-
90-
functionrunTest(){
91-
constfn=tests.shift();
92-
93-
if(!fn){
94-
return;
95-
}
96-
97-
fn(()=>{
98-
setTimeout(runTest,timeout);
99-
});
100-
}
101-
102-
runTest();
81+
});

0 commit comments

Comments
(0)