test: refactor test-tls-connect-simple

refactor var -> const/let refactor process.on('exit') into common.mustCall PR-URL: #9934 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>

Author: russelltsherman

test/parallel/test-tls-connect-simple.js

@@ -1,58 +1,43 @@
 'use strict';
-varcommon=require('../common');
-varassert=require('assert');
+constcommon=require('../common');
 
 if(!common.hasCrypto){
 common.skip('missing crypto');
 return;
 }
-vartls=require('tls');
+consttls=require('tls');
 
-varfs=require('fs');
+constfs=require('fs');
 
-varclientConnected=0;
-varserverConnected=0;
-varserverCloseCallbacks=0;
-varserverCloseEvents=0;
+letserverConnected=0;
 
-varoptions={
+constoptions={
 key: fs.readFileSync(common.fixturesDir+'/keys/agent1-key.pem'),
 cert: fs.readFileSync(common.fixturesDir+'/keys/agent1-cert.pem')
 };
 
-varserver=tls.Server(options,function(socket){
+constserver=tls.Server(options,common.mustCall(function(socket){
 if(++serverConnected===2){
-server.close(function(){
-++serverCloseCallbacks;
-});
-server.on('close',function(){
-++serverCloseEvents;
-});
+server.close(common.mustCall(function(){}));
+server.on('close',common.mustCall(function(){}));
 }
-});
+},2));
 
 server.listen(0,function(){
-varclient1=tls.connect({
+constclient1options={
 port: this.address().port,
 rejectUnauthorized: false
-},function(){
-++clientConnected;
+};
+constclient1=tls.connect(client1options,common.mustCall(function(){
 client1.end();
-});
+}));
 
-varclient2=tls.connect({
+constclient2options={
 port: this.address().port,
 rejectUnauthorized: false
-});
-client2.on('secureConnect',function(){
-++clientConnected;
+};
+constclient2=tls.connect(client2options);
+client2.on('secureConnect',common.mustCall(function(){
 client2.end();
-});
-});
-
-process.on('exit',function(){
-assert.equal(clientConnected,2);
-assert.equal(serverConnected,2);
-assert.equal(serverCloseCallbacks,1);
-assert.equal(serverCloseEvents,1);
+}));
 });