sqlite: handle ?NNN parameters as positional

Author: geeksilva97

src/node_sqlite.cc

@@ -1942,7 +1942,9 @@ bool StatementSync::BindParams(const FunctionCallbackInfo<Value>& args){
  }
 
 for (int i = anon_start; i < args.Length(); ++i){
-while (sqlite3_bind_parameter_name(statement_, anon_idx) != nullptr){
+while (1){
+constchar* param = sqlite3_bind_parameter_name(statement_, anon_idx);
+if (param == nullptr || param[0] == '?') break;
  anon_idx++;
  }
 

test/parallel/test-sqlite-statement-sync.js

@@ -240,6 +240,36 @@ suite('StatementSync.prototype.run()', () =>{
 stmt.run({k: 3,v: 30}),{changes: 1,lastInsertRowid: 3}
 );
 });
+
+test('SQLite defaults unbound ?NNN parameters',(t)=>{
+constdb=newDatabaseSync(nextDb());
+t.after(()=>{db.close();});
+constsetup=db.exec(
+'CREATE TABLE data(key INTEGER PRIMARY KEY, val INTEGER NOT NULL) STRICT;'
+);
+t.assert.strictEqual(setup,undefined);
+conststmt=db.prepare('INSERT INTO data (key, val) VALUES (?1, ?3)');
+
+t.assert.throws(()=>{
+stmt.run(1);
+},{
+code: 'ERR_SQLITE_ERROR',
+message: 'NOT NULL constraint failed: data.val',
+errcode: 1299,
+errstr: 'constraint failed',
+});
+});
+
+test('binds ?NNN params by position',(t)=>{
+constdb=newDatabaseSync(nextDb());
+t.after(()=>{db.close();});
+constsetup=db.exec(
+'CREATE TABLE data(key INTEGER PRIMARY KEY, val INTEGER NOT NULL) STRICT;'
+);
+t.assert.strictEqual(setup,undefined);
+conststmt=db.prepare('INSERT INTO data (key, val) VALUES (?1, ?2)');
+t.assert.deepStrictEqual(stmt.run(1,2),{changes: 1,lastInsertRowid: 1});
+});
 });
 
 suite('StatementSync.prototype.sourceSQL',()=>{