readline: fix question still called after closed

resolve: #42450 PR-URL: #42464 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Darshan Sen <[email protected]>

Author: meixg

doc/api/errors.md

@@ -2802,6 +2802,14 @@ import 'package-name' // supported
 
 `import` with URL schemes other than `file` and `data` is unsupported.
 
+<aid="ERR_USE_AFTER_CLOSE"></a>
+
+### `ERR_USE_AFTER_CLOSE`
+
+> Stability: 1 - Experimental
+
+An attempt was made to use something that was already closed.
+
 <aid="ERR_VALID_PERFORMANCE_ENTRY_TYPE"></a>
 
 ### `ERR_VALID_PERFORMANCE_ENTRY_TYPE`

doc/api/readline.md

@@ -330,6 +330,8 @@ The `callback` function passed to `rl.question()` does not follow the typical
 pattern of accepting an `Error` object or `null` as the first argument.
 The `callback` is called with the provided answer as the only argument.
 
+An error will be thrown if calling `rl.question()` after `rl.close()`.
+
 Example usage:
 
 ```js
@@ -586,6 +588,8 @@ paused.
 If the `readlinePromises.Interface` was created with `output` set to `null` or
 `undefined` the `query` is not written.
 
+If the question is called after `rl.close()`, it returns a rejected promise.
+
 Example usage:
 
 ```mjs
@@ -855,6 +859,8 @@ The `callback` function passed to `rl.question()` does not follow the typical
 pattern of accepting an `Error` object or `null` as the first argument.
 The `callback` is called with the provided answer as the only argument.
 
+An error will be thrown if calling `rl.question()` after `rl.close()`.
+
 Example usage:
 
 ```js

lib/internal/errors.js

@@ -1627,6 +1627,7 @@ E('ERR_UNSUPPORTED_ESM_URL_SCHEME', (url, supported) =>{
 msg+=`. Received protocol '${url.protocol}'`;
 returnmsg;
 },Error);
+E('ERR_USE_AFTER_CLOSE','%s was closed',Error);
 
 // This should probably be a `TypeError`.
 E('ERR_VALID_PERFORMANCE_ENTRY_TYPE',

lib/internal/readline/interface.js

@@ -38,7 +38,10 @@ const{
 
 const{ codes }=require('internal/errors');
 
-const{ERR_INVALID_ARG_VALUE}=codes;
+const{
+ERR_INVALID_ARG_VALUE,
+ERR_USE_AFTER_CLOSE,
+}=codes;
 const{
  validateAbortSignal,
  validateArray,
@@ -398,6 +401,9 @@ class Interface extends InterfaceConstructor{
 }
 
 question(query,cb){
+if(this.closed){
+thrownewERR_USE_AFTER_CLOSE('readline');
+}
 if(this[kQuestionCallback]){
 this.prompt();
 }else{

test/parallel/test-readline-interface.js

@@ -1092,6 +1092,40 @@ for (let i = 0; i < 12; i++){
 rli.close();
 }
 
+// Call question after close
+{
+const[rli,fi]=getInterface({ terminal });
+rli.question('What\'s your name?',common.mustCall((name)=>{
+assert.strictEqual(name,'Node.js');
+rli.close();
+assert.throws(()=>{
+rli.question('How are you?',common.mustNotCall());
+},{
+name: 'Error',
+code: 'ERR_USE_AFTER_CLOSE'
+});
+assert.notStrictEqual(rli.getPrompt(),'How are you?');
+}));
+fi.emit('data','Node.js\n');
+}
+
+// Call promisified question after close
+{
+const[rli,fi]=getInterface({ terminal });
+constquestion=util.promisify(rli.question).bind(rli);
+question('What\'s your name?').then(common.mustCall((name)=>{
+assert.strictEqual(name,'Node.js');
+rli.close();
+question('How are you?')
+.then(common.mustNotCall(),common.expectsError({
+code: 'ERR_USE_AFTER_CLOSE',
+name: 'Error'
+}));
+assert.notStrictEqual(rli.getPrompt(),'How are you?');
+}));
+fi.emit('data','Node.js\n');
+}
+
 // Can create a new readline Interface with a null output argument
 {
 const[rli,fi]=getInterface({output: null, terminal });

test/parallel/test-readline-promises-interface.js

@@ -952,6 +952,23 @@ for (let i = 0; i < 12; i++){
 rli.close();
 }
 
+// Call question after close
+{
+const[rli,fi]=getInterface({ terminal });
+rli.question('What\'s your name?').then(common.mustCall((name)=>{
+assert.strictEqual(name,'Node.js');
+rli.close();
+rli.question('How are you?')
+.then(common.mustNotCall(),common.expectsError({
+code: 'ERR_USE_AFTER_CLOSE',
+name: 'Error'
+}));
+assert.notStrictEqual(rli.getPrompt(),'How are you?');
+}));
+fi.emit('data','Node.js\n');
+}
+
+
 // Can create a new readline Interface with a null output argument
 {
 const[rli,fi]=getInterface({output: null, terminal });