test: fix test-http-status-reason-invalid-chars

saitoxu · addaleax · commit d51c856f11aa · 2016-12-05T03:22:15.000+01:00
Use port 0 instead of common.PORT, and use server address instead of localhost to follow writing test guideline. This is a part of Code And Learn at NodeFest 2016 Challenge in Tokyo. PR-URL: #9572 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/test/parallel/test-http-status-reason-invalid-chars.js b/test/parallel/test-http-status-reason-invalid-chars.js
@@ -3,6 +3,7 @@
 const common = require('../common');
 const assert = require('assert');
 const http = require('http');
+const net = require('net');
 
 function explicit(req, res){
 assert.throws(() =>{
@@ -32,8 +33,10 @@ const server = http.createServer((req, res) =>{
 } else{
 implicit(req, res);
 }
-}).listen(common.PORT, common.mustCall(() =>{
- const url = `http://localhost:${common.PORT}`;
+}).listen(0, common.mustCall(() =>{
+ const addr = server.address().address;
+ const hostname = net.isIPv6(addr) ? `[${addr}1]` : addr;
+ const url = `http://${hostname}:${server.address().port}`;
 let left = 2;
 const check = common.mustCall((res) =>{
 left--;

-Original file line number
+Diff line change
 constcommon=require('../common');
 constassert=require('assert');
 consthttp=require('http');
 +constnet=require('net');
 functionexplicit(req,res){
 assert.throws(()=>{
 }else{
 implicit(req,res);
+}
 -}).listen(common.PORT,common.mustCall(()=>{
 -consturl=`http://localhost:${common.PORT}`;
 +}).listen(0,common.mustCall(()=>{
 +constaddr=server.address().address;
 +consthostname=net.isIPv6(addr) ? `[${addr}1]` : addr;
 +consturl=`http://${hostname}:${server.address().port}`;
 letleft=2;
 constcheck=common.mustCall((res)=>{
 left--;