test: update a few tests to work on OpenBSD

PR-URL: #18543 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>

Author: qbit

test/common/index.js

@@ -29,6 +29,7 @@ exports.isLinuxPPCBE = (process.platform === 'linux') &&
 (os.endianness()==='BE');
 exports.isSunOS=process.platform==='sunos';
 exports.isFreeBSD=process.platform==='freebsd';
+exports.isOpenBSD=process.platform==='openbsd';
 exports.isLinux=process.platform==='linux';
 exports.isOSX=process.platform==='darwin';
 

test/parallel/test-child-process-exec-timeout.js

@@ -16,15 +16,22 @@ const cmd = `"${process.execPath}" "${__filename}" child`;
 
 // Test the case where a timeout is set, and it expires.
 cp.exec(cmd,{timeout: 1},common.mustCall((err,stdout,stderr)=>{
+letsigterm='SIGTERM';
 assert.strictEqual(err.killed,true);
-assert.strictEqual(err.code,null);
+// TODO OpenBSD returns a null signal and 143 for code
+if(common.isOpenBSD){
+assert.strictEqual(err.code,143);
+sigterm=null;
+}else{
+assert.strictEqual(err.code,null);
+}
 // At least starting with Darwin Kernel Version 16.4.0, sending a SIGTERM to a
 // process that is still starting up kills it with SIGKILL instead of SIGTERM.
 // See: https://github.com/libuv/libuv/issues/1226
 if(common.isOSX)
 assert.ok(err.signal==='SIGTERM'||err.signal==='SIGKILL');
 else
-assert.strictEqual(err.signal,'SIGTERM');
+assert.strictEqual(err.signal,sigterm);
 assert.strictEqual(err.cmd,cmd);
 assert.strictEqual(stdout.trim(),'');
 assert.strictEqual(stderr.trim(),'');

test/parallel/test-net-dns-error.js

@@ -6,17 +6,21 @@ const net = require('net');
 
 consthost='*'.repeat(256);
 
+leterrCode='ENOTFOUND';
+if(common.isOpenBSD)
+errCode='EAI_FAIL';
+
 functiondo_not_call(){
 thrownewError('This function should not have been called.');
 }
 
 constsocket=net.connect(42,host,do_not_call);
 socket.on('error',common.mustCall(function(err){
-assert.strictEqual(err.code,'ENOTFOUND');
+assert.strictEqual(err.code,errCode);
 }));
 socket.on('lookup',function(err,ip,type){
 assert(errinstanceofError);
-assert.strictEqual(err.code,'ENOTFOUND');
+assert.strictEqual(err.code,errCode);
 assert.strictEqual(ip,undefined);
 assert.strictEqual(type,undefined);
 });

test/parallel/test-setproctitle.js

@@ -30,7 +30,7 @@ exec(cmd, common.mustCall((error, stdout, stderr) =>{
 assert.strictEqual(stderr,'');
 
 // freebsd always add ' (procname)' to the process title
-if(common.isFreeBSD)
+if(common.isFreeBSD||common.isOpenBSD)
 title+=` (${path.basename(process.execPath)})`;
 
 // omitting trailing whitespace and \n