dns: use url module instead of punycode for IDNA

PR-URL: #35091 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

Author: aduh95

doc/api/intl.md

@@ -51,6 +51,7 @@ option:
 |`String.prototype.toLocale*Case()`| partial (not locale-aware) | full | full | full |
 |[`Number.prototype.toLocaleString()`][]| partial (not locale-aware) | partial/full (depends on OS) | partial (English-only) | full |
 |`Date.prototype.toLocale*String()`| partial (not locale-aware) | partial/full (depends on OS) | partial (English-only) | full |
+|[Legacy URL Parser][]| partial (no IDN support) | full | full | full |
 |[WHATWG URL Parser][]| partial (no IDN support) | full | full | full |
 |[`require('buffer').transcode()`][]| none (function does not exist) | full | full | full |
 |[REPL][]| partial (inaccurate line editing) | full | full | full |
@@ -193,6 +194,7 @@ to be helpful:
 [ECMA-262]: https://tc39.github.io/ecma262/
 [ECMA-402]: https://tc39.github.io/ecma402/
 [ICU]: http://site.icu-project.org/
+[Legacy URL parser]: url.md#url_legacy_url_api
 [REPL]: repl.md#repl_repl
 [Test262]: https://github.com/tc39/test262/tree/HEAD/test/intl402
 [WHATWG URL parser]: url.md#url_the_whatwg_url_api

lib/internal/idna.js

@@ -4,6 +4,6 @@ if (internalBinding('config').hasIntl){
 const{ toASCII, toUnicode }=internalBinding('icu');
 module.exports={ toASCII, toUnicode };
 }else{
-const{toASCII, toUnicode}=require('punycode');
-module.exports={ toASCII, toUnicode };
+const{domainToASCII, domainToUnicode}=require('internal/url');
+module.exports={toASCII: domainToASCII,toUnicode: domainToUnicode};
 }

test/parallel/test-bootstrap-modules.js

@@ -151,7 +151,7 @@ if (!common.isMainThread){
 if(common.hasIntl){
 expectedModules.add('Internal Binding icu');
 }else{
-expectedModules.add('NativeModule punycode');
+expectedModules.add('NativeModule url');
 }
 
 if(process.features.inspector){

test/parallel/test-url-format.js

@@ -1,8 +1,11 @@
 'use strict';
-require('../common');
+constcommon=require('../common');
 constassert=require('assert');
 consturl=require('url');
 
+if(!common.hasIntl)
+common.skip('missing Intl');
+
 // Formatting tests to verify that it'll format slightly wonky content to a
 // valid URL.
 constformatTests={

test/parallel/test-url-parse-format.js

@@ -1,5 +1,9 @@
 'use strict';
-require('../common');
+constcommon=require('../common');
+
+if(!common.hasIntl)
+common.skip('missing Intl');
+
 constassert=require('assert');
 constinspect=require('util').inspect;