deps: cherry-pick aa6ce3e from upstream V8

Original commit message: [log][api] introduce public CodeEventListener API Introduce a new public API called CodeEventListener to allow embedders to better support external profilers and other diagnostic tools without relying on unsupported methods like --perf-basic-prof. Bug: v8:7694 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I063cc965394d59401358757634c9ea84c11517e9 Co-authored-by: Daniel Beckert <[email protected]> Reviewed-on: https://chromium-review.googlesource.com/1028770 Commit-Queue: Yang Guo <[email protected]> Reviewed-by: Hannes Payer <[email protected]> Reviewed-by: Yang Guo <[email protected]> Reviewed-by: Andreas Haas <[email protected]> Cr-Commit-Position: refs/heads/master@{#53382} Refs: v8/v8@aa6ce3e Backport-PR-URL: #21668 PR-URL: #21079 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yang Guo <[email protected]>

Author: targos

common.gypi

@@ -29,7 +29,7 @@
 
 # Reset this number to 0 on major V8 upgrades.
 # Increment by one for each non-official patch applied to deps/v8.
-'v8_embedder_string': '-node.2',
+'v8_embedder_string': '-node.3',
 
 # Enable disassembler for `--print-code` v8 options
 'v8_enable_disassembler': 1,

deps/v8/include/v8-profiler.h

@@ -992,6 +992,76 @@ struct HeapStatsUpdate{
 uint32_t size; // New value of size field for the interval with this index.
 };
 
+#defineCODE_EVENTS_LIST(V) \
+V(Builtin) \
+ V(Callback) \
+ V(Eval) \
+ V(Function) \
+ V(InterpretedFunction) \
+ V(Handler) \
+ V(BytecodeHandler) \
+ V(LazyCompile) \
+ V(RegExp) \
+ V(Script) \
+ V(Stub)
+
+/**
+ * Note that this enum may be extended in the future. Please include a default
+ * case if this enum is used in a switch statement.
+*/
+enum CodeEventType{
+kUnknownType = 0
+#defineV(Name) , k##Name##Type
+CODE_EVENTS_LIST(V)
+#undef V
+};
+
+/**
+ * Representation of a code creation event
+*/
+classV8_EXPORT CodeEvent{
+public:
+uintptr_tGetCodeStartAddress();
+size_tGetCodeSize();
+ Local<String> GetFunctionName();
+ Local<String> GetScriptName();
+intGetScriptLine();
+intGetScriptColumn();
+/**
+ * NOTE (mmarchini): We can't allocate objects in the heap when we collect
+ * existing code, and both the code type and the comment are not stored in the
+ * heap, so we return those as const char*.
+*/
+ CodeEventType GetCodeType();
+constchar* GetComment();
+
+staticconstchar* GetCodeEventTypeName(CodeEventType code_event_type);
+};
+
+/**
+ * Interface to listen to code creation events.
+*/
+classV8_EXPORT CodeEventHandler{
+public:
+/**
+ * Creates a new listener for the |isolate|. The isolate must be initialized.
+ * The listener object must be disposed after use by calling |Dispose| method.
+ * Multiple listeners can be created for the same isolate.
+*/
+explicitCodeEventHandler(Isolate* isolate);
+virtual~CodeEventHandler();
+
+virtualvoidHandle(CodeEvent* code_event) = 0;
+
+voidEnable();
+voidDisable();
+
+private:
+CodeEventHandler();
+CodeEventHandler(const CodeEventHandler&);
+ CodeEventHandler& operator=(const CodeEventHandler&);
+void* internal_listener_;
+};
 
 } // namespace v8
 

deps/v8/src/api.cc

@@ -10104,6 +10104,70 @@ void CpuProfiler::SetIdle(bool is_idle){
  isolate->SetIdle(is_idle);
 }
 
+uintptr_tCodeEvent::GetCodeStartAddress(){
+returnreinterpret_cast<i::CodeEvent*>(this)->code_start_address;
+}
+
+size_tCodeEvent::GetCodeSize(){
+returnreinterpret_cast<i::CodeEvent*>(this)->code_size;
+}
+
+Local<String> CodeEvent::GetFunctionName(){
+return ToApiHandle<String>(
+reinterpret_cast<i::CodeEvent*>(this)->function_name);
+}
+
+Local<String> CodeEvent::GetScriptName(){
+return ToApiHandle<String>(
+reinterpret_cast<i::CodeEvent*>(this)->script_name);
+}
+
+intCodeEvent::GetScriptLine(){
+returnreinterpret_cast<i::CodeEvent*>(this)->script_line;
+}
+
+intCodeEvent::GetScriptColumn(){
+returnreinterpret_cast<i::CodeEvent*>(this)->script_column;
+}
+
+CodeEventType CodeEvent::GetCodeType(){
+returnreinterpret_cast<i::CodeEvent*>(this)->code_type;
+}
+
+constchar* CodeEvent::GetComment(){
+returnreinterpret_cast<i::CodeEvent*>(this)->comment;
+}
+
+constchar* CodeEvent::GetCodeEventTypeName(CodeEventType code_event_type){
+switch (code_event_type){
+casekUnknownType:
+return"Unknown";
+#defineV(Name) \
+case k##Name##Type: \
+return #Name;
+CODE_EVENTS_LIST(V)
+#undef V
+ }
+}
+
+CodeEventHandler::CodeEventHandler(Isolate* isolate){
+ internal_listener_ =
+newi::ExternalCodeEventListener(reinterpret_cast<i::Isolate*>(isolate));
+}
+
+CodeEventHandler::~CodeEventHandler(){
+deletereinterpret_cast<i::ExternalCodeEventListener*>(internal_listener_);
+}
+
+voidCodeEventHandler::Enable(){
+reinterpret_cast<i::ExternalCodeEventListener*>(internal_listener_)
+ ->StartListening(this);
+}
+
+voidCodeEventHandler::Disable(){
+reinterpret_cast<i::ExternalCodeEventListener*>(internal_listener_)
+ ->StopListening();
+}
 
 static i::HeapGraphEdge* ToInternal(const HeapGraphEdge* edge){
 returnconst_cast<i::HeapGraphEdge*>(

deps/v8/src/code-events.h

@@ -24,32 +24,38 @@ class WasmCode;
 using WasmName = Vector<constchar>
 } // namespace wasm
 
-#defineLOG_EVENTS_AND_TAGS_LIST(V) \
-V(CODE_CREATION_EVENT, "code-creation") \
-V(CODE_DISABLE_OPT_EVENT, "code-disable-optimization") \
-V(CODE_MOVE_EVENT, "code-move") \
-V(CODE_DELETE_EVENT, "code-delete") \
-V(CODE_MOVING_GC, "code-moving-gc") \
-V(SHARED_FUNC_MOVE_EVENT, "sfi-move") \
-V(SNAPSHOT_CODE_NAME_EVENT, "snapshot-code-name") \
-V(TICK_EVENT, "tick") \
-V(BUILTIN_TAG, "Builtin") \
-V(CALLBACK_TAG, "Callback") \
-V(EVAL_TAG, "Eval") \
-V(FUNCTION_TAG, "Function") \
-V(INTERPRETED_FUNCTION_TAG, "InterpretedFunction") \
-V(HANDLER_TAG, "Handler") \
-V(BYTECODE_HANDLER_TAG, "BytecodeHandler") \
-V(LAZY_COMPILE_TAG, "LazyCompile") \
-V(REG_EXP_TAG, "RegExp") \
-V(SCRIPT_TAG, "Script") \
-V(STUB_TAG, "Stub") \
-V(NATIVE_FUNCTION_TAG, "Function") \
-V(NATIVE_LAZY_COMPILE_TAG, "LazyCompile") \
-V(NATIVE_SCRIPT_TAG, "Script")
+#defineLOG_EVENTS_LIST(V) \
+V(CODE_CREATION_EVENT, code-creation) \
+V(CODE_DISABLE_OPT_EVENT, code-disable-optimization) \
+V(CODE_MOVE_EVENT, code-move) \
+V(CODE_DELETE_EVENT, code-delete) \
+V(CODE_MOVING_GC, code-moving-gc) \
+V(SHARED_FUNC_MOVE_EVENT, sfi-move) \
+V(SNAPSHOT_CODE_NAME_EVENT, snapshot-code-name) \
+V(TICK_EVENT, tick)
+
+#defineTAGS_LIST(V) \
+V(BUILTIN_TAG, Builtin) \
+V(CALLBACK_TAG, Callback) \
+V(EVAL_TAG, Eval) \
+V(FUNCTION_TAG, Function) \
+V(INTERPRETED_FUNCTION_TAG, InterpretedFunction) \
+V(HANDLER_TAG, Handler) \
+V(BYTECODE_HANDLER_TAG, BytecodeHandler) \
+V(LAZY_COMPILE_TAG, LazyCompile) \
+V(REG_EXP_TAG, RegExp) \
+V(SCRIPT_TAG, Script) \
+V(STUB_TAG, Stub) \
+V(NATIVE_FUNCTION_TAG, Function) \
+V(NATIVE_LAZY_COMPILE_TAG, LazyCompile) \
+V(NATIVE_SCRIPT_TAG, Script)
 // Note that 'NATIVE_' cases for functions and scripts are mapped onto
 // original tags when writing to the log.
 
+#defineLOG_EVENTS_AND_TAGS_LIST(V) \
+LOG_EVENTS_LIST(V) \
+TAGS_LIST(V)
+
 #definePROFILE(the_isolate, Call) (the_isolate)->code_event_dispatcher()->Call;
 
 classCodeEventListener{
@@ -85,6 +91,8 @@ class CodeEventListener{
 enum DeoptKind{kSoft, kLazy, kEager };
 virtualvoidCodeDeoptEvent(Code* code, DeoptKind kind, Address pc,
 int fp_to_sp_delta) = 0;
+
+virtualboolis_listening_to_code_events(){returnfalse}
 };
 
 classCodeEventDispatcher{
@@ -101,6 +109,14 @@ class CodeEventDispatcher{
  base::LockGuard<base::Mutex> guard(&mutex_);
  listeners_.erase(listener);
  }
+boolIsListeningToCodeEvents(){
+for (auto it : listeners_){
+if (it->is_listening_to_code_events()){
+returntrue;
+ }
+ }
+returnfalse;
+ }
 
 #defineCODE_EVENT_DISPATCH(code) \
  base::LockGuard<base::Mutex> guard(&mutex_); \

deps/v8/src/compiler.cc

@@ -84,8 +84,9 @@ void LogFunctionCompilation(CodeEventListener::LogEventsAndTags tag,
 // Log the code generation. If source information is available include
 // script name and line number. Check explicitly whether logging is
 // enabled as finding the line number is not free.
-if (!isolate->logger()->is_logging_code_events() &&
- !isolate->is_profiling() && !FLAG_log_function_events){
+if (!isolate->logger()->is_listening_to_code_events() &&
+ !isolate->is_profiling() && !FLAG_log_function_events &&
+ !isolate->code_event_dispatcher()->IsListeningToCodeEvents()){
 return;
  }
 

deps/v8/src/compiler/wasm-compiler.cc

@@ -3952,7 +3952,8 @@ Node* WasmGraphBuilder::AtomicOp(wasm::WasmOpcode opcode, Node* const* inputs,
 
 namespace{
 boolmust_record_function_compilation(Isolate* isolate){
-return isolate->logger()->is_logging_code_events() || isolate->is_profiling();
+return isolate->logger()->is_listening_to_code_events() ||
+ isolate->is_profiling();
 }
 
 PRINTF_FORMAT(4, 5)

deps/v8/src/heap/mark-compact.cc

@@ -2414,7 +2414,7 @@ void MarkCompactCollectorBase::CreateAndExecuteEvacuationTasks(
 
 constbool profiling =
 heap()->isolate()->is_profiling() ||
-heap()->isolate()->logger()->is_logging_code_events() ||
+heap()->isolate()->logger()->is_listening_to_code_events() ||
 heap()->isolate()->heap_profiler()->is_tracking_object_moves() ||
 heap()->has_heap_object_allocation_tracker();
  ProfilingMigrationObserver profiling_observer(heap());

deps/v8/src/isolate.cc

@@ -2892,7 +2892,7 @@ void CreateOffHeapTrampolines(Isolate* isolate){
 // thus collected by the GC.
  builtins->set_builtin(i, *trampoline);
 
-if (isolate->logger()->is_logging_code_events() ||
+if (isolate->logger()->is_listening_to_code_events() ||
  isolate->is_profiling()){
  isolate->logger()->LogCodeObject(*trampoline);
  }

deps/v8/src/isolate.h

@@ -57,6 +57,7 @@ class BuiltinsConstantsTableBuilder;
 classCallInterfaceDescriptorData;
 classCancelableTaskManager;
 classCodeEventDispatcher;
+classExternalCodeEventListener;
 classCodeGenerator;
 classCodeRange;
 classCodeStubDescriptor;