Skip to content

Commit dafaff3

Browse files
Benjamin Gruenbaumtargos
authored andcommitted
test: remove unused config
process.maxTickDepth was removed in v0.12 a whole while ago and was mostly removed from our code base. There are still some places it was left in old benchmarks and tests. This PR removes setting the value in those tests and benchmarks. PR-URL: #21985 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]>
1 parent a569ae4 commit dafaff3

File tree

5 files changed

+6
-15
lines changed

5 files changed

+6
-15
lines changed

‎benchmark/process/next-tick-depth-args.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@ const bench = common.createBenchmark(main,{
55
n: [12e6]
66
});
77

8-
process.maxTickDepth=Infinity;
9-
108
functionmain({ n }){
119
letcounter=n;
1210
functioncb4(arg1,arg2,arg3,arg4){

‎benchmark/process/next-tick-depth.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@ const bench = common.createBenchmark(main,{
44
n: [12e6]
55
});
66

7-
process.maxTickDepth=Infinity;
8-
97
functionmain({ n }){
108
letcounter=n;
119
bench.start();

‎test/parallel/test-next-tick-intentional-starvation.js‎

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,8 @@
2323
require('../common');
2424
constassert=require('assert');
2525

26-
// this is the inverse of test-next-tick-starvation.
27-
// it verifies that process.nextTick will *always* come before other
28-
// events, up to the limit of the process.maxTickDepth value.
29-
30-
// WARNING: unsafe!
31-
process.maxTickDepth=Infinity;
26+
// this is the inverse of test-next-tick-starvation. it verifies
27+
// that process.nextTick will *always* come before other events
3228

3329
letran=false;
3430
letstarved=false;

‎test/parallel/test-stream2-read-sync-stack.js‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,13 @@
2222
'use strict';
2323
constcommon=require('../common');
2424
constReadable=require('stream').Readable;
25+
26+
// This tests synchronous read callbacks and verifies that even if they nest
27+
// heavily the process handles it without an error
28+
2529
constr=newReadable();
2630
constN=256*1024;
2731

28-
// Go ahead and allow the pathological case for this test.
29-
// Yes, it's an infinite loop, that's the point.
30-
process.maxTickDepth=N+2;
31-
3232
letreads=0;
3333
r._read=function(n){
3434
constchunk=reads++===N ? null : Buffer.allocUnsafe(1);

‎test/sequential/test-next-tick-error-spin.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ if (process.argv[2] !== 'child'){
3939

4040
constdomain=require('domain');
4141
constd=domain.create();
42-
process.maxTickDepth=10;
4342

4443
// in the error handler, we trigger several MakeCallback events
4544
d.on('error',function(){

0 commit comments

Comments
(0)