http: specify _implicitHeader in OutgoingMessage

yorkie · cjihrig · commit db3a7e83eba8 · 2016-08-10T12:46:53.000-04:00
PR-URL: #7949 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
diff --git a/lib/_http_outgoing.js b/lib/_http_outgoing.js
@@ -413,6 +413,9 @@ OutgoingMessage.prototype._renderHeaders = function(){
 return headers;
 };
 
+OutgoingMessage.prototype._implicitHeader = function(){
+ throw new Error('_implicitHeader() method is not implemented');
+};
 
 Object.defineProperty(OutgoingMessage.prototype, 'headersSent',{
 configurable: true,
diff --git a/test/parallel/test-http-outgoing-proto.js b/test/parallel/test-http-outgoing-proto.js
@@ -0,0 +1,14 @@
+'use strict';
+require('../common');
+const assert = require('assert');
+
+const http = require('http');
+const OutgoingMessage = http.OutgoingMessage;
+const ClientRequest = http.ClientRequest;
+const ServerResponse = http.ServerResponse;
+
+assert.throws(OutgoingMessage.prototype._implicitHeader);
+assert.strictEqual(
+ typeof ClientRequest.prototype._implicitHeader, 'function');
+assert.strictEqual(
+ typeof ServerResponse.prototype._implicitHeader, 'function');

-Original file line number
+Diff line change
 returnheaders;
 };
 +OutgoingMessage.prototype._implicitHeader=function(){
 +thrownewError('_implicitHeader() method is not implemented');
 +};
 Object.defineProperty(OutgoingMessage.prototype,'headersSent',{
 configurable: true,
-Original file line number
+Diff line change
@@ @@ -0,0 +1,14 @@ @@
 +'use strict';
 +require('../common');
 +constassert=require('assert');
++
 +consthttp=require('http');
 +constOutgoingMessage=http.OutgoingMessage;
 +constClientRequest=http.ClientRequest;
 +constServerResponse=http.ServerResponse;
++
 +assert.throws(OutgoingMessage.prototype._implicitHeader);
 +assert.strictEqual(
 +typeofClientRequest.prototype._implicitHeader,'function');
 +assert.strictEqual(
 +typeofServerResponse.prototype._implicitHeader,'function');