test: fix and improve debug-break-on-uncaught

This test runs based on a expectation that the stderr will get the string 'Debugger listening on port'. But the actual message printed to stderr has changed to 'Debugger listening on host:port'. So the the actuals tests did not even start and eventually timeout. Apart from that, changed `var`s to `let`s or `const`s. Refs: #10361 PR-URL: #10370 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]

Author: thefourtheye

test/debugger/test-debug-break-on-uncaught.js

@@ -5,7 +5,7 @@ const spawn = require('child_process').spawn;
 constcommon=require('../common');
 constdebug=require('_debugger');
 
-varscenarios=[];
+constscenarios=[];
 
 addScenario('global.js',2);
 addScenario('timeout.js',2);
@@ -21,34 +21,33 @@ function addScenario(scriptName, throwsOnLine){
 }
 
 functionrun(){
-varnext=scenarios.shift();
+constnext=scenarios.shift();
 if(next)next();
 }
 
 functionrunScenario(scriptName,throwsOnLine,next){
-console.log('**[ %s ]**',scriptName);
-varasserted=false;
-varport=common.PORT;
+letasserted=false;
+constport=common.PORT;
 
-vartestScript=path.join(
+consttestScript=path.join(
 common.fixturesDir,
 'uncaught-exceptions',
 scriptName
 );
 
-varchild=spawn(process.execPath,['--debug-brk='+port,testScript]);
+constchild=spawn(process.execPath,['--debug-brk='+port,testScript]);
 child.on('close',function(){
 assert(asserted,'debugger did not pause on exception');
 if(next)next();
 });
 
-varexceptions=[];
+constexceptions=[];
 
-varstderr='';
+letstderr='';
 
 functionstderrListener(data){
 stderr+=data;
-if(stderr.includes('Debugger listening on port')){
+if(stderr.includes('Debugger listening on ')){
 setTimeout(setupClient.bind(null,runTest),200);
 child.stderr.removeListener('data',stderrListener);
 }
@@ -58,7 +57,7 @@ function runScenario(scriptName, throwsOnLine, next){
 child.stderr.on('data',stderrListener);
 
 functionsetupClient(callback){
-varclient=newdebug.Client();
+constclient=newdebug.Client();
 
 client.once('ready',callback.bind(null,client));
 
@@ -83,14 +82,14 @@ function runScenario(scriptName, throwsOnLine, next){
 enabled: true
 }
 },
-function(error,result){
+function(error){
 assert.ifError(error);
 
 client.on('exception',function(event){
 exceptions.push(event.body);
 });
 
-client.reqContinue(function(error,result){
+client.reqContinue(function(error){
 assert.ifError(error);
 setTimeout(assertHasPaused.bind(null,client),100);
 });