tools: simplify buffer-constructor rule

PR-URL: #17572 Reviewed-By: Anatoli Papirovski <[email protected]>

Author: cjihrig

tools/eslint-rules/buffer-constructor.js

@@ -10,16 +10,11 @@
 constmsg='Use of the Buffer() constructor has been deprecated. '+
 'Please use either Buffer.alloc(), Buffer.allocUnsafe(), '+
 'or Buffer.from()';
-
-functiontest(context,node){
-if(node.callee.name==='Buffer'){
-context.report(node,msg);
-}
-}
+constastSelector='NewExpression[callee.name="Buffer"],'+
+'CallExpression[callee.name="Buffer"]';
 
 module.exports=function(context){
 return{
-'NewExpression': (node)=>test(context,node),
-'CallExpression': (node)=>test(context,node)
+[astSelector]: (node)=>context.report(node,msg)
 };
 };