test: ensure assertions are reachable in test/es-module

PR-URL: #60501 Reviewed-By: Chemi Atlow <[email protected]>

Author: aduh95

test/es-module/test-esm-assert-strict.mjs

@@ -1,5 +1,7 @@
 import'../common/index.mjs';
+// eslint-disable-next-line node-core/must-call-assert
 importassert,{strict}from'assert';
+// eslint-disable-next-line node-core/must-call-assert
 importassertStrictfrom'assert/strict';
 
 assert.strictEqual(strict,assertStrict);

test/es-module/test-esm-assertionless-json-import.js

@@ -1,7 +1,7 @@
 // Flags: --experimental-loader ./test/fixtures/es-module-loaders/assertionless-json-import.mjs
 'use strict';
 constcommon=require('../common');
-const{ strictEqual }=require('assert');
+constassert=require('assert');
 
 asyncfunctiontest(){
 {
@@ -13,10 +13,10 @@ async function test(){
 ),
 ]);
 
-strictEqual(secret0.default.ofLife,42);
-strictEqual(secret1.default.ofLife,42);
-strictEqual(secret0.default,secret1.default);
-strictEqual(secret0,secret1);
+assert.strictEqual(secret0.default.ofLife,42);
+assert.strictEqual(secret1.default.ofLife,42);
+assert.strictEqual(secret0.default,secret1.default);
+assert.strictEqual(secret0,secret1);
 }
 
 {
@@ -28,10 +28,10 @@ async function test(){
 ),
 ]);
 
-strictEqual(secret0.default.ofLife,42);
-strictEqual(secret1.default.ofLife,42);
-strictEqual(secret0.default,secret1.default);
-strictEqual(secret0,secret1);
+assert.strictEqual(secret0.default.ofLife,42);
+assert.strictEqual(secret1.default.ofLife,42);
+assert.strictEqual(secret0.default,secret1.default);
+assert.strictEqual(secret0,secret1);
 }
 
 {
@@ -43,10 +43,10 @@ async function test(){
 ),
 ]);
 
-strictEqual(secret0.default.ofLife,42);
-strictEqual(secret1.default.ofLife,42);
-strictEqual(secret0.default,secret1.default);
-strictEqual(secret0,secret1);
+assert.strictEqual(secret0.default.ofLife,42);
+assert.strictEqual(secret1.default.ofLife,42);
+assert.strictEqual(secret0.default,secret1.default);
+assert.strictEqual(secret0,secret1);
 }
 
 {
@@ -58,10 +58,10 @@ async function test(){
 ),
 ]);
 
-strictEqual(secret0.default.ofLife,42);
-strictEqual(secret1.default.ofLife,42);
-strictEqual(secret0.default,secret1.default);
-strictEqual(secret0,secret1);
+assert.strictEqual(secret0.default.ofLife,42);
+assert.strictEqual(secret1.default.ofLife,42);
+assert.strictEqual(secret0.default,secret1.default);
+assert.strictEqual(secret0,secret1);
 }
 
 {
@@ -73,8 +73,8 @@ async function test(){
 ),
 ]);
 
-strictEqual(secret0.default.ofLife,42);
-strictEqual(secret1.default.ofLife,42);
+assert.strictEqual(secret0.default.ofLife,42);
+assert.strictEqual(secret1.default.ofLife,42);
 }
 }
 

test/es-module/test-esm-cjs-named-error.mjs

@@ -1,5 +1,5 @@
 import'../common/index.mjs';
-import{rejects}from'assert';
+importassertfrom'assert';
 
 constfixtureBase='../fixtures/es-modules/package-cjs-named-error';
 
@@ -23,55 +23,55 @@ const expectedPackageHack =
 
 constexpectedBare=errTemplate('deep-fail','comeOn','{comeOn }');
 
-awaitrejects(async()=>{
+awaitassert.rejects(async()=>{
 awaitimport(`${fixtureBase}/single-quote.mjs`);
 },{
 name: 'SyntaxError',
 message: expectedRelative
 },'should support relative specifiers with single quotes');
 
-awaitrejects(async()=>{
+awaitassert.rejects(async()=>{
 awaitimport(`${fixtureBase}/double-quote.mjs`);
 },{
 name: 'SyntaxError',
 message: expectedRelative
 },'should support relative specifiers with double quotes');
 
-awaitrejects(async()=>{
+awaitassert.rejects(async()=>{
 awaitimport(`${fixtureBase}/renamed-import.mjs`);
 },{
 name: 'SyntaxError',
 message: expectedRenamed
 },'should correctly format named imports with renames');
 
-awaitrejects(async()=>{
+awaitassert.rejects(async()=>{
 awaitimport(`${fixtureBase}/multi-line.mjs`);
 },{
 name: 'SyntaxError',
 message: expectedWithoutExample,
 },'should correctly format named imports across multiple lines');
 
-awaitrejects(async()=>{
+awaitassert.rejects(async()=>{
 awaitimport(`${fixtureBase}/json-hack.mjs`);
 },{
 name: 'SyntaxError',
 message: expectedPackageHack
 },'should respect recursive package.json for module type');
 
-awaitrejects(async()=>{
+awaitassert.rejects(async()=>{
 awaitimport(`${fixtureBase}/bare-import-single.mjs`);
 },{
 name: 'SyntaxError',
 message: expectedBare
 },'should support bare specifiers with single quotes');
 
-awaitrejects(async()=>{
+awaitassert.rejects(async()=>{
 awaitimport(`${fixtureBase}/bare-import-double.mjs`);
 },{
 name: 'SyntaxError',
 message: expectedBare
 },'should support bare specifiers with double quotes');
 
-awaitrejects(async()=>{
+awaitassert.rejects(async()=>{
 awaitimport(`${fixtureBase}/escaped-single-quote.mjs`);
 },/importpkgfrom'\.\/oh'no\.cjs'/,'should support relative specifiers with escaped single quote');

test/es-module/test-esm-custom-exports.mjs

@@ -1,10 +1,10 @@
 // Flags: --conditions=custom-condition -C another
 import{mustCall}from'../common/index.mjs';
-import{strictEqual}from'assert';
+importassertfrom'assert';
 import{requireFixture,importFixture}from'../fixtures/pkgexports.mjs';
 [requireFixture,importFixture].forEach((loadFixture)=>{
 loadFixture('pkgexports/condition')
 .then(mustCall((actual)=>{
-strictEqual(actual.default,'from custom condition');
+assert.strictEqual(actual.default,'from custom condition');
 }));
 });

test/es-module/test-esm-default-type.mjs

@@ -1,7 +1,7 @@
 import'../common/index.mjs';
-import{strictEqual}from'assert';
+importassertfrom'assert';
 
 importasdffrom
 '../fixtures/es-modules/package-type-module/nested-default-type/module.js';
 
-strictEqual(asdf,'asdf');
+assert.strictEqual(asdf,'asdf');