test: improve statwatcher async_hooks test

Modify the `fs.watchFile()` async hooks test to be more accurate; currently, it relies on undocumented methods and the fact that they use `MakeCallback()` even though there is always a JS stack below. PR-URL: #21244 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>

Author: addaleax

test/async-hooks/test-statwatcher.js

@@ -1,21 +1,29 @@
 'use strict';
 
 constcommon=require('../common');
-constcommonPath=require.resolve('../common');
+consttmpdir=require('../common/tmpdir');
 constassert=require('assert');
 constinitHooks=require('./init-hooks');
 const{ checkInvocations }=require('./hook-checks');
 constfs=require('fs');
+constpath=require('path');
 
 if(!common.isMainThread)
 common.skip('Worker bootstrapping works differently -> different async IDs');
 
+tmpdir.refresh();
+
+constfile1=path.join(tmpdir.path,'file1');
+constfile2=path.join(tmpdir.path,'file2');
+fs.writeFileSync(file1,'foo');
+fs.writeFileSync(file2,'bar');
+
 consthooks=initHooks();
 hooks.enable();
 
 functiononchange(){}
 // install first file watcher
-fs.watchFile(__filename,onchange);
+constw1=fs.watchFile(file1,{interval: 10},onchange);
 
 letas=hooks.activitiesOfTypes('STATWATCHER');
 assert.strictEqual(as.length,1);
@@ -28,7 +36,7 @@ checkInvocations(statwatcher1,{init: 1 },
 'watcher1: when started to watch file');
 
 // install second file watcher
-fs.watchFile(commonPath,onchange);
+constw2=fs.watchFile(file2,{interval: 10},onchange);
 as=hooks.activitiesOfTypes('STATWATCHER');
 assert.strictEqual(as.length,2);
 
@@ -41,19 +49,29 @@ checkInvocations(statwatcher1,{init: 1 },
 checkInvocations(statwatcher2,{init: 1},
 'watcher2: when started to watch second file');
 
-// remove first file watcher
-fs.unwatchFile(__filename);
-checkInvocations(statwatcher1,{init: 1,before: 1,after: 1},
-'watcher1: when unwatched first file');
-checkInvocations(statwatcher2,{init: 1},
-'watcher2: when unwatched first file');
+setTimeout(()=>fs.writeFileSync(file1,'foo++'),
+common.platformTimeout(100));
+w1.once('change',common.mustCall(()=>{
+setImmediate(()=>{
+checkInvocations(statwatcher1,{init: 1,before: 1,after: 1},
+'watcher1: when unwatched first file');
+checkInvocations(statwatcher2,{init: 1},
+'watcher2: when unwatched first file');
 
-// remove second file watcher
-fs.unwatchFile(commonPath);
-checkInvocations(statwatcher1,{init: 1,before: 1,after: 1},
-'watcher1: when unwatched second file');
-checkInvocations(statwatcher2,{init: 1,before: 1,after: 1},
-'watcher2: when unwatched second file');
+setTimeout(()=>fs.writeFileSync(file2,'bar++'),
+common.platformTimeout(100));
+w2.once('change',common.mustCall(()=>{
+setImmediate(()=>{
+checkInvocations(statwatcher1,{init: 1,before: 1,after: 1},
+'watcher1: when unwatched second file');
+checkInvocations(statwatcher2,{init: 1,before: 1,after: 1},
+'watcher2: when unwatched second file');
+fs.unwatchFile(file1);
+fs.unwatchFile(file2);
+});
+}));
+});
+}));
 
 process.on('exit',onexit);