lib,test: fix bug in InternalSocketAddress

InternalSocketAddress must set [kDetails] in order for the inherited properties to function correctly. Co-authored-by: Tobias Nießen <[email protected]> PR-URL: #44618 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

Author: tniessen

lib/internal/socketaddress.js

@@ -142,6 +142,12 @@ class InternalSocketAddress extends JSTransferable{
 constructor(handle){
 super();
 this[kHandle]=handle;
+this[kDetail]=this[kHandle]?.detail({
+address: undefined,
+port: undefined,
+family: undefined,
+flowlabel: undefined,
+});
 }
 }
 

test/parallel/test-socketaddress.js

@@ -1,3 +1,4 @@
+// Flags: --expose-internals
 'use strict';
 
 constcommon=require('../common');
@@ -10,6 +11,15 @@ const{
  SocketAddress,
 }=require('net');
 
+const{
+ InternalSocketAddress,
+}=require('internal/socketaddress');
+const{ internalBinding }=require('internal/test/binding');
+const{
+SocketAddress: _SocketAddress,
+AF_INET
+}=internalBinding('block_list');
+
 {
 constsa=newSocketAddress();
 strictEqual(sa.address,'127.0.0.1');
@@ -108,3 +118,20 @@ const{
 throws(()=>newSocketAddress({flowlabel: -1}),{
 code: 'ERR_OUT_OF_RANGE'
 });
+
+{
+// Test that the internal helper class InternalSocketAddress correctly
+// inherits from SocketAddress and that it does not throw when its properties
+// are accessed.
+
+constaddress='127.0.0.1';
+constport=8080;
+constflowlabel=0;
+consthandle=new_SocketAddress(address,port,AF_INET,flowlabel);
+constaddr=newInternalSocketAddress(handle);
+ok(addrinstanceofSocketAddress);
+strictEqual(addr.address,address);
+strictEqual(addr.port,port);
+strictEqual(addr.family,'ipv4');
+strictEqual(addr.flowlabel,flowlabel);
+}