crypto: rename generateKeyPairEdDSA

Now that support for X25519 and X448 has been added, this function is not used exclusively for EdDSA keys anymore. PR-URL: #26900 Refs: #26774 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Sam Roberts <[email protected]>

Author: tniessen

lib/internal/crypto/keygen.js

@@ -5,7 +5,7 @@ const{
  generateKeyPairRSA,
  generateKeyPairDSA,
  generateKeyPairEC,
-generateKeyPairEdDSA,
+generateKeyPairNid,
 EVP_PKEY_ED25519,
 EVP_PKEY_ED448,
 EVP_PKEY_X25519,
@@ -217,10 +217,10 @@ function check(type, options, callback){
 id=EVP_PKEY_X448;
 break;
 }
-impl=(wrap)=>generateKeyPairEdDSA(id,
-publicFormat,publicType,
-privateFormat,privateType,
-cipher,passphrase,wrap);
+impl=(wrap)=>generateKeyPairNid(id,
+publicFormat,publicType,
+privateFormat,privateType,
+cipher,passphrase,wrap);
 }
 break;
 default:

src/node_crypto.cc

@@ -5835,9 +5835,9 @@ class ECKeyPairGenerationConfig : public KeyPairGenerationConfig{
 constint param_encoding_;
 };
 
-classEdDSAKeyPairGenerationConfig : publicKeyPairGenerationConfig{
+classNidKeyPairGenerationConfig : publicKeyPairGenerationConfig{
 public:
-explicitEdDSAKeyPairGenerationConfig(int id) : id_(id){}
+explicitNidKeyPairGenerationConfig(int id) : id_(id){}
 
  EVPKeyCtxPointer Setup() override{
 returnEVPKeyCtxPointer(EVP_PKEY_CTX_new_id(id_, nullptr));
@@ -6020,11 +6020,11 @@ void GenerateKeyPairEC(const FunctionCallbackInfo<Value>& args){
 GenerateKeyPair(args, 2, std::move(config));
 }
 
-voidGenerateKeyPairEdDSA(const FunctionCallbackInfo<Value>& args){
+voidGenerateKeyPairNid(const FunctionCallbackInfo<Value>& args){
 CHECK(args[0]->IsInt32());
 constint id = args[0].As<Int32>()->Value();
  std::unique_ptr<KeyPairGenerationConfig> config(
-newEdDSAKeyPairGenerationConfig(id));
+newNidKeyPairGenerationConfig(id));
 GenerateKeyPair(args, 1, std::move(config));
 }
 
@@ -6447,7 +6447,7 @@ void Initialize(Local<Object> target,
  env->SetMethod(target, "generateKeyPairRSA", GenerateKeyPairRSA);
  env->SetMethod(target, "generateKeyPairDSA", GenerateKeyPairDSA);
  env->SetMethod(target, "generateKeyPairEC", GenerateKeyPairEC);
- env->SetMethod(target, "generateKeyPairEdDSA", GenerateKeyPairEdDSA);
+ env->SetMethod(target, "generateKeyPairNid", GenerateKeyPairNid);
 NODE_DEFINE_CONSTANT(target, EVP_PKEY_ED25519);
 NODE_DEFINE_CONSTANT(target, EVP_PKEY_ED448);
 NODE_DEFINE_CONSTANT(target, EVP_PKEY_X25519);