http: fix permanent deoptimizations

PR-URL: #12456 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]>

Author: mscdex

lib/_http_agent.js

@@ -130,13 +130,14 @@ Agent.prototype.getName = function getName(options){
 returnname;
 };
 
-Agent.prototype.addRequest=functionaddRequest(req,options){
+Agent.prototype.addRequest=functionaddRequest(req,options,port/*legacy*/,
+localAddress/*legacy*/){
 // Legacy API: addRequest(req, host, port, localAddress)
 if(typeofoptions==='string'){
 options={
 host: options,
-port: arguments[2],
-localAddress: arguments[3]
+ port,
+ localAddress
 };
 }
 

lib/_http_client.js

@@ -127,8 +127,8 @@ function ClientRequest(options, cb){
 'Expected "'+expectedProtocol+'"');
 }
 
-constdefaultPort=options.defaultPort||
-this.agent&&this.agent.defaultPort;
+vardefaultPort=options.defaultPort||
+this.agent&&this.agent.defaultPort;
 
 varport=options.port=options.port||defaultPort||80;
 varhost=options.host=validateHost(options.hostname,'hostname')||
@@ -226,7 +226,7 @@ function ClientRequest(options, cb){
 
 varcalled=false;
 
-constoncreate=(err,socket)=>{
+varoncreate=(err,socket)=>{
 if(called)
 return;
 called=true;
@@ -238,14 +238,15 @@ function ClientRequest(options, cb){
 this._deferToConnect(null,null,()=>this._flush());
 };
 
+varnewSocket;
 if(this.socketPath){
 this._last=true;
 this.shouldKeepAlive=false;
-constoptionsPath={
+varoptionsPath={
 path: this.socketPath,
 timeout: this.timeout
 };
-constnewSocket=this.agent.createConnection(optionsPath,oncreate);
+newSocket=this.agent.createConnection(optionsPath,oncreate);
 if(newSocket&&!called){
 called=true;
 this.onSocket(newSocket);
@@ -270,7 +271,7 @@ function ClientRequest(options, cb){
 this._last=true;
 this.shouldKeepAlive=false;
 if(typeofoptions.createConnection==='function'){
-constnewSocket=options.createConnection(options,oncreate);
+newSocket=options.createConnection(options,oncreate);
 if(newSocket&&!called){
 called=true;
 this.onSocket(newSocket);