test: refactor test-http-client-readable

* var -> const * remove function names where V8 inference is as good or better * add function names where there is no V8 inference * assert.equal -> strictEqual * move assertion from exit handler to response end handler PR-URL: #9344 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

Author: Trott

test/parallel/test-http-client-readable.js

@@ -1,21 +1,21 @@
 'use strict';
 constcommon=require('../common');
-varassert=require('assert');
-varhttp=require('http');
-varutil=require('util');
+constassert=require('assert');
+consthttp=require('http');
+constutil=require('util');
 
-varDuplex=require('stream').Duplex;
+constDuplex=require('stream').Duplex;
 
 functionFakeAgent(){
 http.Agent.call(this);
 }
 util.inherits(FakeAgent,http.Agent);
 
-FakeAgent.prototype.createConnection=functioncreateConnection(){
-vars=newDuplex();
+FakeAgent.prototype.createConnection=function(){
+consts=newDuplex();
 varonce=false;
 
-s._read=function_read(){
+s._read=function(){
 if(once)
 returnthis.push(null);
 once=true;
@@ -27,11 +27,11 @@ FakeAgent.prototype.createConnection = function createConnection(){
 };
 
 // Blackhole
-s._write=function_write(data,enc,cb){
+s._write=function(data,enc,cb){
 cb();
 };
 
-s.destroy=s.destroySoon=functiondestroy(){
+s.destroy=s.destroySoon=function(){
 this.writable=false;
 };
 
@@ -40,17 +40,15 @@ FakeAgent.prototype.createConnection = function createConnection(){
 
 varreceived='';
 
-varreq=http.request({
+constreq=http.request({
 agent: newFakeAgent()
-},common.mustCall(function(res){
-res.on('data',function(chunk){
+},common.mustCall(functionrequestCallback(res){
+res.on('data',functiondataCallback(chunk){
 received+=chunk;
 });
 
-res.on('end',common.mustCall(function(){}));
+res.on('end',common.mustCall(functionendCallback(){
+assert.strictEqual(received,'hello world');
+}));
 }));
 req.end();
-
-process.on('exit',function(){
-assert.equal(received,'hello world');
-});