Skip to content

Commit e6c308e

Browse files
Shigeki OhtsuMylesBorins
authored andcommitted
deps: add -no_rand_screen to openssl s_client
In openssl s_client on Windows, RAND_screen() is invoked to initialize random state but it takes several seconds in each connection. This added -no_rand_screen to openssl s_client on Windows to skip RAND_screen() and gets a better performance in the unit test of test-tls-server-verify. Do not enable this except to use in the unit test. Fixes: #1461 PR-URL: #1836 Reviewed-By: Ben Noordhuis <[email protected]>
1 parent 7d68488 commit e6c308e

File tree

2 files changed

+20
-2
lines changed

2 files changed

+20
-2
lines changed

‎deps/openssl/openssl/apps/app_rand.c‎

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,16 @@ int app_RAND_load_file(const char *file, BIO *bio_e, int dont_warn)
124124
charbuffer[200];
125125

126126
#ifdefOPENSSL_SYS_WINDOWS
127-
RAND_screen();
127+
/*
128+
* allocate 2 to dont_warn not to use RAND_screen() via
129+
* -no_rand_screen option in s_client
130+
*/
131+
if (dont_warn!=2){
132+
BIO_printf(bio_e, "Loading 'screen' into random state -");
133+
BIO_flush(bio_e);
134+
RAND_screen();
135+
BIO_printf(bio_e, " done\n");
136+
}
128137
#endif
129138

130139
if (file==NULL)

‎deps/openssl/openssl/apps/s_client.c‎

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -236,6 +236,7 @@ static BIO *bio_c_msg = NULL;
236236
staticintc_quiet=0;
237237
staticintc_ign_eof=0;
238238
staticintc_brief=0;
239+
staticintc_no_rand_screen=0;
239240

240241
#ifndefOPENSSL_NO_PSK
241242
/* Default PSK identity and key */
@@ -451,6 +452,10 @@ static void sc_usage(void)
451452
" -keymatexport label - Export keying material using label\n");
452453
BIO_printf(bio_err,
453454
" -keymatexportlen len - Export len bytes of keying material (default 20)\n");
455+
#ifdefOPENSSL_SYS_WINDOWS
456+
BIO_printf(bio_err,
457+
" -no_rand_screen - Do not use RAND_screen() to initialize random state\n");
458+
#endif
454459
}
455460

456461
#ifndefOPENSSL_NO_TLSEXT
@@ -1144,6 +1149,10 @@ int MAIN(int argc, char **argv)
11441149
keymatexportlen=atoi(*(++argv));
11451150
if (keymatexportlen==0)
11461151
goto bad;
1152+
#ifdefOPENSSL_SYS_WINDOWS
1153+
} elseif (strcmp(*argv, "-no_rand_screen") ==0){
1154+
c_no_rand_screen=1;
1155+
#endif
11471156
} else{
11481157
BIO_printf(bio_err, "unknown option %s\n", *argv);
11491158
badop=1;
@@ -1260,7 +1269,7 @@ int MAIN(int argc, char **argv)
12601269
if (!load_excert(&exc, bio_err))
12611270
goto end;
12621271

1263-
if (!app_RAND_load_file(NULL, bio_err, 1) &&inrand== NULL
1272+
if (!app_RAND_load_file(NULL, bio_err, ++c_no_rand_screen) &&inrand==NULL
12641273
&& !RAND_status()){
12651274
BIO_printf(bio_err,
12661275
"warning, not much extra random data, consider using the -rand option\n");

0 commit comments

Comments
(0)