readline: rename deDupeHistory option

Renames `options.deDupeHistory` → `options.removeHistoryDuplicates` for `readline.createInterface(options)`. The option name `removeHistoryDuplicates` is preferable to the semantically identical name `deDupeHistory` because "dedupe" (short for "deduplication") is obscure and neologistic while `removeHistoryDuplicates` is clear, though verbose. Updates tests and documentation for this option accordingly. PR-URL: #11950 Ref: #2982 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: James M Snell <[email protected]>

Author: DannyNemer

doc/api/readline.md

@@ -363,9 +363,9 @@ added: v0.1.98
 `crlfDelay` milliseconds, both `\r` and `\n` will be treated as separate
  end-of-line input. Default to `100` milliseconds.
 `crlfDelay` will be coerced to `[100, 2000]` range.
-*`deDupeHistory`{boolean} If `true`, when a new input line added to the
- history list duplicates an older one, this removes the older line from the
- list. Defaults to `false`.
+*`removeHistoryDuplicates`{boolean} If `true`, when a new input line added
+to the history list duplicates an older one, this removes the older line
+from the list. Defaults to `false`.
 
 The `readline.createInterface()` method creates a new `readline.Interface`
 instance.

lib/readline.js

@@ -39,7 +39,7 @@ function Interface(input, output, completer, terminal){
 
 EventEmitter.call(this);
 varhistorySize;
-vardeDupeHistory=false;
+varremoveHistoryDuplicates=false;
 letcrlfDelay;
 letprompt='> ';
 
@@ -49,7 +49,7 @@ function Interface(input, output, completer, terminal){
 completer=input.completer;
 terminal=input.terminal;
 historySize=input.historySize;
-deDupeHistory=input.deDupeHistory;
+removeHistoryDuplicates=input.removeHistoryDuplicates;
 if(input.prompt!==undefined){
 prompt=input.prompt;
 }
@@ -82,7 +82,7 @@ function Interface(input, output, completer, terminal){
 this.output=output;
 this.input=input;
 this.historySize=historySize;
-this.deDupeHistory=!!deDupeHistory;
+this.removeHistoryDuplicates=!!removeHistoryDuplicates;
 this.crlfDelay=Math.max(kMincrlfDelay,
 Math.min(kMaxcrlfDelay,crlfDelay>>>0));
 
@@ -252,7 +252,7 @@ Interface.prototype._addHistory = function(){
 if(this.line.trim().length===0)returnthis.line;
 
 if(this.history.length===0||this.history[0]!==this.line){
-if(this.deDupeHistory){
+if(this.removeHistoryDuplicates){
 // Remove older history line if identical to new one
 constdupIndex=this.history.indexOf(this.line);
 if(dupIndex!==-1)this.history.splice(dupIndex,1);

test/parallel/test-readline-interface.js

@@ -303,14 +303,14 @@ function isWarned(emitter){
 returnfalse;
 });
 
-// duplicate lines are removed from history when `options.deDupeHistory`
-// is `true`
+// duplicate lines are removed from history when
+// `options.removeHistoryDuplicates` is `true`
 fi=newFakeInput();
 rli=newreadline.Interface({
 input: fi,
 output: fi,
 terminal: true,
-deDupeHistory: true
+removeHistoryDuplicates: true
 });
 expectedLines=['foo','bar','baz','bar','bat','bat'];
 callCount=0;
@@ -333,14 +333,14 @@ function isWarned(emitter){
 assert.strictEqual(callCount,0);
 rli.close();
 
-// duplicate lines are not removed from history when `options.deDupeHistory`
-// is `false`
+// duplicate lines are not removed from history when
+// `options.removeHistoryDuplicates` is `false`
 fi=newFakeInput();
 rli=newreadline.Interface({
 input: fi,
 output: fi,
 terminal: true,
-deDupeHistory: false
+removeHistoryDuplicates: false
 });
 expectedLines=['foo','bar','baz','bar','bat','bat'];
 callCount=0;