tools: fix nits in tools/doc/type-parser.js

PR-URL: #19612 Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Khaidi Chu <[email protected]>

Author: vsemozhetbyt

tools/doc/type-parser.js

@@ -1,7 +1,7 @@
 'use strict';
-constnodeDocUrl='';
+
 constjsDocPrefix='https://developer.mozilla.org/en-US/docs/Web/JavaScript/';
-constjsDocUrl=`${jsDocPrefix}Reference/Global_Objects/`;
+
 constjsPrimitiveUrl=`${jsDocPrefix}Data_structures`;
 constjsPrimitives={
 'boolean': 'Boolean',
@@ -12,6 +12,8 @@ const jsPrimitives ={
 'symbol': 'Symbol',
 'undefined': 'Undefined'
 };
+
+constjsGlobalObjectsUrl=`${jsDocPrefix}Reference/Global_Objects/`;
 constjsGlobalTypes=[
 'Array','ArrayBuffer','AsyncFunction','DataView','Date','Error',
 'EvalError','Float32Array','Float64Array','Function','Generator',
@@ -21,7 +23,8 @@ const jsGlobalTypes = [
 'Uint16Array','Uint32Array','Uint8Array','Uint8ClampedArray','WeakMap',
 'WeakSet'
 ];
-consttypeMap={
+
+constcustomTypesMap={
 'Iterable':
 `${jsDocPrefix}Reference/Iteration_protocols#The_iterable_protocol`,
 'Iterator':
@@ -95,41 +98,43 @@ const typeMap ={
 
 constarrayPart=/(?:\[])+$/;
 
-module.exports={
-toLink: function(typeInput){
-consttypeLinks=[];
-typeInput=typeInput.replace('{','').replace('}','');
-consttypeTexts=typeInput.split('|');
-
-typeTexts.forEach(function(typeText){
-typeText=typeText.trim();
-if(typeText){
-lettypeUrl=null;
-
-// To support type[], type[][] etc., we store the full string
-// and use the bracket-less version to lookup the type URL
-consttypeTextFull=typeText;
-typeText=typeText.replace(arrayPart,'');
-
-constprimitive=jsPrimitives[typeText.toLowerCase()];
-
-if(primitive!==undefined){
-typeUrl=`${jsPrimitiveUrl}#${primitive}_type`;
-}elseif(jsGlobalTypes.indexOf(typeText)!==-1){
-typeUrl=jsDocUrl+typeText;
-}elseif(typeMap[typeText]){
-typeUrl=nodeDocUrl+typeMap[typeText];
-}
-
-if(typeUrl){
-typeLinks.push(`
- <a href="${typeUrl}" class="type">&lt;${typeTextFull}&gt;</a>`);
-}else{
-typeLinks.push(`<span class="type">&lt;${typeTextFull}&gt;</span>`);
-}
+functiontoLink(typeInput){
+consttypeLinks=[];
+typeInput=typeInput.replace('{','').replace('}','');
+consttypeTexts=typeInput.split('|');
+
+typeTexts.forEach((typeText)=>{
+typeText=typeText.trim();
+if(typeText){
+lettypeUrl=null;
+
+// To support type[], type[][] etc., we store the full string
+// and use the bracket-less version to lookup the type URL
+consttypeTextFull=typeText;
+typeText=typeText.replace(arrayPart,'');
+
+constprimitive=jsPrimitives[typeText.toLowerCase()];
+
+if(primitive!==undefined){
+typeUrl=`${jsPrimitiveUrl}#${primitive}_type`;
+}elseif(jsGlobalTypes.includes(typeText)){
+typeUrl=`${jsGlobalObjectsUrl}${typeText}`;
+}elseif(customTypesMap[typeText]){
+typeUrl=customTypesMap[typeText];
 }
-});
 
-returntypeLinks.length ? typeLinks.join(' | ') : typeInput;
-}
-};
+if(typeUrl){
+typeLinks.push(
+`<a href="${typeUrl}" class="type">&lt;${typeTextFull}&gt;</a>`);
+}else{
+typeLinks.push(`<span class="type">&lt;${typeTextFull}&gt;</span>`);
+}
+}else{
+thrownewError(`Empty type slot: ${typeInput}`);
+}
+});
+
+returntypeLinks.length ? typeLinks.join(' | ') : typeInput;
+}
+
+module.exports={ toLink };