test: refactor test after review

PR-URL: #18999 Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>

Author: billywhizz

test/parallel/test-http-client-spurious-aborted.js

@@ -3,37 +3,26 @@
 constcommon=require('../common');
 consthttp=require('http');
 constassert=require('assert');
-constfs=require('fs');
+const{ Writable }=require('stream');
 constCountdown=require('../common/countdown');
 
-functioncleanup(fname){
-try{
-if(fs.statSync(fname))fs.unlinkSync(fname);
-}catch(err){}
-}
-
 constN=2;
-constfname='/dev/null';
 letabortRequest=true;
 
 constserver=http.Server(common.mustCall((req,res)=>{
 constheaders={'Content-Type': 'text/plain'};
 headers['Content-Length']=50;
 constsocket=res.socket;
 res.writeHead(200,headers);
-setTimeout(()=>res.write('aaaaaaaaaa'),100);
-setTimeout(()=>res.write('bbbbbbbbbb'),200);
-setTimeout(()=>res.write('cccccccccc'),300);
-setTimeout(()=>res.write('dddddddddd'),400);
+res.write('aaaaaaaaaabbbbbbbbbbccccccccccdddddddddd');
 if(abortRequest){
-setTimeout(()=>socket.destroy(),600);
+process.nextTick(()=>socket.destroy());
 }else{
-setTimeout(()=>res.end('eeeeeeeeee'),1000);
+process.nextTick(()=>res.end('eeeeeeeeee'));
 }
 },N));
 
 server.listen(0,common.mustCall(()=>{
-cleanup(fname);
 download();
 }));
 
@@ -53,13 +42,17 @@ function download(){
 assert.strictEqual(res.statusCode,200);
 assert.strictEqual(res.headers.connection,'close');
 letaborted=false;
-constfstream=fs.createWriteStream(fname);
-res.pipe(fstream);
+constwritable=newWritable({
+write(chunk,encoding,callback){
+callback();
+}
+});
+res.pipe(writable);
 const_handle=res.socket._handle;
 _handle._close=res.socket._handle.close;
 _handle.close=function(callback){
 _handle._close();
-// set readable to true event though request is complete
+// set readable to true even though request is complete
 if(res.complete)res.readable=true;
 callback();
 };
@@ -70,9 +63,8 @@ function download(){
 aborted=true;
 });
 res.on('error',common.mustNotCall());
-fstream.on('finish',()=>{
+writable.on('finish',()=>{
 assert.strictEqual(aborted,abortRequest);
-cleanup(fname);
 finishCountdown.dec();
 if(finishCountdown.remaining===0)return;
 abortRequest=false;// next one should be a good response