lib: remove deprecated string methods

PR-URL: #50592 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: James M Snell <[email protected]>

Author: MrJithil

lib/_http_agent.js

@@ -38,7 +38,7 @@ const{
  StringPrototypeIndexOf,
  StringPrototypeSplit,
  StringPrototypeStartsWith,
-StringPrototypeSubstr,
+StringPrototypeSubstring,
  Symbol,
 }=primordials;
 
@@ -363,7 +363,7 @@ function calculateServerName(options, req){
 // Leading '[', but no ']'. Need to do something...
 servername=hostHeader;
 }else{
-servername=StringPrototypeSubstr(hostHeader,1,index-1);
+servername=StringPrototypeSubstring(hostHeader,1,index);
 }
 }else{
 servername=StringPrototypeSplit(hostHeader,':',1)[0];

lib/internal/main/print_help.js

@@ -11,7 +11,7 @@ const{
  RegExpPrototypeSymbolReplace,
  StringPrototypeLocaleCompare,
  StringPrototypeSlice,
-StringPrototypeTrimLeft,
+StringPrototypeTrimStart,
  StringPrototypeRepeat,
  SafeMap,
 }=primordials;
@@ -180,7 +180,7 @@ function format(
 else
 text+=StringPrototypeRepeat(' ',firstColumn-displayName.length);
 
-text+=StringPrototypeTrimLeft(
+text+=StringPrototypeTrimStart(
 indent(fold(displayHelpText,secondColumn),firstColumn))+'\n';
 }
 

lib/repl.js

@@ -90,7 +90,7 @@ const{
  StringPrototypeSplit,
  StringPrototypeStartsWith,
  StringPrototypeTrim,
-StringPrototypeTrimLeft,
+StringPrototypeTrimStart,
  StringPrototypeToLocaleLowerCase,
  Symbol,
  SyntaxError,
@@ -1326,7 +1326,7 @@ function complete(line, callback){
 letcompleteOn,group;
 
 // Ignore right whitespace. It could change the outcome.
-line=StringPrototypeTrimLeft(line);
+line=StringPrototypeTrimStart(line);
 
 letfilter='';