deps: V8: cherry-pick 2059ee813359

Original commit message: [heap] Make CompactTransitionArray deserializer friendly Add a pre-loop over transition arrays during compaction, that checks whether compaction is needed at all, and whether any of the entries are still uninitialized values as part of deserialization (and therefore no other targets can be dead). Bails out of compaction early if this is the case. Bug: v8:11305 Change-Id: I27af792a8a0bd3df17892f54ac95ed15e4bdfcc0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2622910 Reviewed-by: Ulan Degenbaev <[email protected]> Commit-Queue: Leszek Swirski <[email protected]> Cr-Commit-Position: refs/heads/master@{#72038} Refs: v8/v8@2059ee8 PR-URL: #36139 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>

Author: targos

common.gypi

@@ -36,7 +36,7 @@
 
 # Reset this number to 0 on major V8 upgrades.
 # Increment by one for each non-official patch applied to deps/v8.
-'v8_embedder_string': '-node.17',
+'v8_embedder_string': '-node.18',
 
 ##### V8 defaults for Node.js #####
 

deps/v8/src/heap/mark-compact.cc

@@ -2288,11 +2288,45 @@ void MarkCompactCollector::ClearFullMapTransitions(){
  }
 }
 
+// Returns false if no maps have died, or if the transition array is
+// still being deserialized.
+boolMarkCompactCollector::TransitionArrayNeedsCompaction(
+ TransitionArray transitions, int num_transitions){
+for (int i = 0; i < num_transitions; ++i){
+ MaybeObject raw_target = transitions.GetRawTarget(i);
+if (raw_target.IsSmi()){
+// This target is still being deserialized,
+DCHECK(isolate()->has_active_deserializer());
+DCHECK_EQ(raw_target.ToSmi(), Deserializer::uninitialized_field_value());
+#ifdef DEBUG
+// Targets can only be dead iff this array is fully deserialized.
+for (int i = 0; i < num_transitions; ++i){
+DCHECK(!non_atomic_marking_state()->IsWhite(transitions.GetTarget(i)));
+ }
+#endif
+returnfalse;
+ } elseif (non_atomic_marking_state()->IsWhite(
+TransitionsAccessor::GetTargetFromRaw(raw_target))){
+#ifdef DEBUG
+// Targets can only be dead iff this array is fully deserialized.
+for (int i = 0; i < num_transitions; ++i){
+DCHECK(!transitions.GetRawTarget(i).IsSmi());
+ }
+#endif
+returntrue;
+ }
+ }
+returnfalse;
+}
+
 boolMarkCompactCollector::CompactTransitionArray(Map map,
  TransitionArray transitions,
  DescriptorArray descriptors){
 DCHECK(!map.is_prototype_map());
 int num_transitions = transitions.number_of_entries();
+if (!TransitionArrayNeedsCompaction(transitions, num_transitions)){
+returnfalse;
+ }
 bool descriptors_owner_died = false;
 int transition_index = 0;
 // Compact all live transitions to the left.

deps/v8/src/heap/mark-compact.h

@@ -681,6 +681,8 @@ class MarkCompactCollector final : public MarkCompactCollectorBase{
 voidTrimEnumCache(Map map, DescriptorArray descriptors);
 boolCompactTransitionArray(Map map, TransitionArray transitions,
  DescriptorArray descriptors);
+boolTransitionArrayNeedsCompaction(TransitionArray transitions,
+int num_transitions);
 
 // After all reachable objects have been marked those weak map entries
 // with an unreachable key are removed from all encountered weak maps.