test: improve code coverage in timers

juanarbol · BethGriggs · commit ee9694668b9a · 2019-04-16T22:14:01.000+01:00
PR-URL: #26310 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
diff --git a/test/parallel/test-timers-refresh.js b/test/parallel/test-timers-refresh.js
@@ -30,6 +30,19 @@ const{setUnrefTimeout } = require('internal/timers');
 strictEqual(timer.refresh(), timer);
 }
 
+// should throw with non-functions
+{
+ const expectedError ={
+ code: 'ERR_INVALID_CALLBACK',
+ message: 'Callback must be a function'
+ };
+
+ [null, true, false, 0, 1, NaN, '', 'foo',{}, Symbol()].forEach((cb) =>{
+ common.expectsError(() => setUnrefTimeout(cb),
+ expectedError);
+ });
+}
+
 // unref pooled timer
{
 let called = false;

-Original file line number
+Diff line change
 strictEqual(timer.refresh(),timer);
+}
 +// should throw with non-functions
 +{
 +constexpectedError={
 +code: 'ERR_INVALID_CALLBACK',
 +message: 'Callback must be a function'
 +};
++
 +[null,true,false,0,1,NaN,'','foo',{},Symbol()].forEach((cb)=>{
 +common.expectsError(()=>setUnrefTimeout(cb),
 +expectedError);
 +});
 +}
++
 // unref pooled timer
+{
 letcalled=false;