build: ensure v8_pointer_compression_sandbox is enabled on 64bit

codebytere · RafaelGSS · commit ee97c045b440 · 2024-08-05T11:15:43.000-03:00
PR-URL: #53884 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
diff --git a/common.gypi b/common.gypi
@@ -113,6 +113,7 @@
 ['target_arch in "arm ia32 mips mipsel ppc"',{
 'v8_enable_pointer_compression': 0,
 'v8_enable_31bit_smis_on_64bit_arch': 0,
+ 'v8_enable_sandbox': 0
 }],
 ['target_arch in "ppc64 s390x"',{
 'v8_enable_backtrace': 1,
diff --git a/configure.py b/configure.py
@@ -1640,6 +1640,7 @@ def configure_v8(o, configs):
 o['variables']['v8_enable_maglev'] = B(not options.v8_disable_maglev and
 o['variables']['target_arch'] in maglev_enabled_architectures)
 o['variables']['v8_enable_pointer_compression'] = 1 if options.enable_pointer_compression else 0
+ o['variables']['v8_enable_sandbox'] = 1 if options.enable_pointer_compression else 0
 o['variables']['v8_enable_31bit_smis_on_64bit_arch'] = 1 if options.enable_pointer_compression else 0
 o['variables']['v8_enable_shared_ro_heap'] = 0 if options.enable_pointer_compression or options.disable_shared_ro_heap else 1
 o['variables']['v8_enable_extensible_ro_snapshot'] = 0

-Original file line number
+Diff line change
 o['variables']['v8_enable_maglev'] =B(notoptions.v8_disable_maglevand
 o['variables']['target_arch'] inmaglev_enabled_architectures)
 o['variables']['v8_enable_pointer_compression'] =1ifoptions.enable_pointer_compressionelse0
 +o['variables']['v8_enable_sandbox'] =1ifoptions.enable_pointer_compressionelse0
 o['variables']['v8_enable_31bit_smis_on_64bit_arch'] =1ifoptions.enable_pointer_compressionelse0
 o['variables']['v8_enable_shared_ro_heap'] =0ifoptions.enable_pointer_compressionoroptions.disable_shared_ro_heapelse1
 o['variables']['v8_enable_extensible_ro_snapshot'] =0