Skip to content

Commit eea50fa

Browse files
committed
dns: make promise API fully constructed from lib/internal/dns/promises
1 parent 331088f commit eea50fa

File tree

3 files changed

+17
-6
lines changed

3 files changed

+17
-6
lines changed

‎lib/dns.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -386,8 +386,6 @@ ObjectDefineProperties(module.exports,{
386386
get(){
387387
if(promises===null){
388388
promises=require('internal/dns/promises');
389-
promises.setServers=defaultResolverSetServers;
390-
promises.setDefaultResultOrder=setDefaultResultOrder;
391389
}
392390
returnpromises;
393391
}

‎lib/dns/promises.js‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
11
'use strict';
22

3-
constdnsPromises=require('internal/dns/promises');
4-
dnsPromises.setServers=require('dns').setServers;
5-
module.exports=dnsPromises;
3+
module.exports=require('internal/dns/promises');

‎lib/internal/dns/promises.js‎

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@ const{
1616
validateTries,
1717
emitInvalidHostnameWarning,
1818
getDefaultVerbatim,
19+
setDefaultResultOrder,
20+
setDefaultResolver,
1921
}=require('internal/dns/utils');
2022
const{ codes, dnsException }=require('internal/errors');
2123
const{ toASCII }=require('internal/idna');
@@ -312,6 +314,19 @@ Resolver.prototype.resolve = function resolve(hostname, rrtype){
312314
returnReflectApply(resolver,this,[hostname]);
313315
};
314316

317+
functiondefaultResolverSetServers(servers){
318+
constresolver=newResolver();
315319

316-
module.exports={ lookup, lookupService, Resolver };
320+
resolver.setServers(servers);
321+
setDefaultResolver(resolver);
322+
bindDefaultResolver(module.exports,Resolver.prototype);
323+
}
324+
325+
module.exports={
326+
lookup,
327+
lookupService,
328+
Resolver,
329+
setDefaultResultOrder,
330+
setServers: defaultResolverSetServers,
331+
};
317332
bindDefaultResolver(module.exports,Resolver.prototype);

0 commit comments

Comments
(0)