test: update arrow function style

This commit applies new arrow function linting rules across the codebase. As it turns out, the only offenders were in the test directory. PR-URL: #4813 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Saúl Ibarra Corretgé <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Roman Reiss <[email protected]>

Author: cjihrig

test/common.js

@@ -470,7 +470,7 @@ exports.fail = function(msg){
 // A stream to push an array into a REPL
 functionArrayStream(){
 this.run=function(data){
-data.forEach(line=>{
+data.forEach((line)=>{
 this.emit('data',line+'\n');
 });
 };

test/parallel/test-assert.js

@@ -485,7 +485,7 @@ testBlockTypeError(assert.throws, undefined);
 testBlockTypeError(assert.doesNotThrow,undefined);
 
 // https://github.com/nodejs/node/issues/3275
-assert.throws(()=>{throw'error';},err=>err==='error');
-assert.throws(()=>{thrownewError();},err=>errinstanceofError);
+assert.throws(()=>{throw'error';},(err)=>err==='error');
+assert.throws(()=>{thrownewError();},(err)=>errinstanceofError);
 
 console.log('All OK');

test/parallel/test-async-wrap-check-providers.js

@@ -20,7 +20,7 @@ keyList.splice(0, 1);
 
 
 functioninit(id){
-keyList=keyList.filter(e=>e!=pkeys[id]);
+keyList=keyList.filter((e)=>e!=pkeys[id]);
 }
 
 functionnoop(){}

test/parallel/test-child-process-spawn-shell.js

@@ -26,7 +26,7 @@ let echoOutput = ''
 
 assert.strictEqual(echo.spawnargs[echo.spawnargs.length-1].replace(/"/g,''),
 'echo foo');
-echo.stdout.on('data',data=>{
+echo.stdout.on('data',(data)=>{
 echoOutput+=data;
 });
 echo.on('close',common.mustCall((code,signal)=>{
@@ -41,7 +41,7 @@ const command = cp.spawn(cmd,{
 });
 letcommandOutput='';
 
-command.stdout.on('data',data=>{
+command.stdout.on('data',(data)=>{
 commandOutput+=data;
 });
 command.on('close',common.mustCall((code,signal)=>{
@@ -56,7 +56,7 @@ const env = cp.spawn(`"${process.execPath}" -pe process.env.BAZ`,{
 });
 letenvOutput='';
 
-env.stdout.on('data',data=>{
+env.stdout.on('data',(data)=>{
 envOutput+=data;
 });
 env.on('close',common.mustCall((code,signal)=>{

test/parallel/test-cluster-disconnect-handles.js

@@ -31,7 +31,7 @@ if (cluster.isMaster){
 // scanner but is ignored by atoi(3). Heinous hack.
 cluster.setupMaster({execArgv: [`--debug=${common.PORT}.`]});
 constworker=cluster.fork();
-worker.on('message',common.mustCall(message=>{
+worker.on('message',common.mustCall((message)=>{
 assert.strictEqual(Array.isArray(message),true);
 assert.strictEqual(message[0],'listening');
 letcontinueRecv=false;
@@ -40,9 +40,9 @@ if (cluster.isMaster){
 constdebugClient=net.connect({ host,port: common.PORT});
 constprotocol=newProtocol();
 debugClient.setEncoding('utf8');
-debugClient.on('data',data=>protocol.execute(data));
+debugClient.on('data',(data)=>protocol.execute(data));
 debugClient.once('connect',common.mustCall(()=>{
-protocol.onResponse=common.mustCall(res=>{
+protocol.onResponse=common.mustCall((res)=>{
 protocol.onResponse=(res)=>{
 // It can happen that the first continue was sent before the break
 // event was received. If that's the case, send also a continue from
@@ -85,7 +85,7 @@ if (cluster.isMaster){
 throwex;
 });
 }else{
-constserver=net.createServer(socket=>socket.pipe(socket));
+constserver=net.createServer((socket)=>socket.pipe(socket));
 constcb=()=>{
 process.send(['listening',server.address()]);
 debugger;

test/parallel/test-debug-no-context.js

@@ -17,7 +17,7 @@ proc.on('exit', common.mustCall((exitCode, signalCode) =>{
 }));
 letstdout='';
 proc.stdout.setEncoding('utf8');
-proc.stdout.on('data',data=>stdout+=data);
+proc.stdout.on('data',(data)=>stdout+=data);
 process.on('exit',()=>{
 assert(stdout.includes('Promise{42 }'));
 assert(stdout.includes('Promise{1337 }'));

test/parallel/test-debug-port-cluster.js

@@ -15,7 +15,7 @@ const child = spawn(process.execPath, args);
 child.stderr.setEncoding('utf8');
 
 letstderr='';
-child.stderr.on('data',data=>{
+child.stderr.on('data',(data)=>{
 stderr+=data;
 if(child.killed!==true&&stderr.includes('all workers are running'))
 child.kill();

test/parallel/test-net-socket-local-address.js

@@ -13,7 +13,7 @@ var conns = 0;
 varclientLocalPorts=[];
 varserverRemotePorts=[];
 constclient=newnet.Socket();
-constserver=net.createServer(socket=>{
+constserver=net.createServer((socket)=>{
 serverRemotePorts.push(socket.remotePort);
 socket.end();
 });

test/parallel/test-process-emit.js

@@ -3,15 +3,15 @@ const common = require('../common');
 constassert=require('assert');
 constsym=Symbol();
 
-process.on('normal',common.mustCall(data=>{
+process.on('normal',common.mustCall((data)=>{
 assert.strictEqual(data,'normalData');
 }));
 
-process.on(sym,common.mustCall(data=>{
+process.on(sym,common.mustCall((data)=>{
 assert.strictEqual(data,'symbolData');
 }));
 
-process.on('SIGPIPE',common.mustCall(data=>{
+process.on('SIGPIPE',common.mustCall((data)=>{
 assert.strictEqual(data,'signalData');
 }));
 

test/parallel/test-repl-require.js

@@ -7,7 +7,7 @@ const net = require('net');
 process.chdir(common.fixturesDir);
 constrepl=require('repl');
 
-constserver=net.createServer(conn=>{
+constserver=net.createServer((conn)=>{
 repl.start('',conn).on('exit',()=>{
 conn.destroy();
 server.close();
@@ -22,7 +22,7 @@ var answer = ''
 server.listen(options,function(){
 constconn=net.connect(options);
 conn.setEncoding('utf8');
-conn.on('data',data=>answer+=data);
+conn.on('data',(data)=>answer+=data);
 conn.write('require("baz")\n.exit\n');
 });