net: check for close on stream, not parent

'close' event isn't emitted on a TLS connection if it's been written to (but 'end' and 'finish' events are). PR-URL: #25026Fixes: #24984 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>

Author: davedoesdev

lib/net.js

@@ -362,8 +362,8 @@ Socket.prototype._final = function(cb){
 };
 
 
-functionafterShutdown(status,handle){
-varself=handle[owner_symbol];
+functionafterShutdown(status){
+varself=this.handle[owner_symbol];
 
 debug('afterShutdown destroyed=%j',self.destroyed,
 self._readableState);

test/parallel/test-tls-close-event-after-write.js

@@ -0,0 +1,41 @@
+'use strict';
+constcommon=require('../common');
+
+if(!common.hasCrypto)
+common.skip('missing crypto');
+
+// Issue #24984
+// 'close' event isn't emitted on a TLS connection if it's been written to
+// (but 'end' and 'finish' events are). Without a fix, this test won't exit.
+
+consttls=require('tls');
+constfixtures=require('../common/fixtures');
+letcconn=null;
+letsconn=null;
+
+functiontest(){
+if(cconn&&sconn){
+cconn.resume();
+sconn.resume();
+sconn.end(Buffer.alloc(1024*1024));
+cconn.end();
+}
+}
+
+constserver=tls.createServer({
+key: fixtures.readKey('agent1-key.pem'),
+cert: fixtures.readKey('agent1-cert.pem')
+},function(c){
+c.on('close',function(){
+server.close();
+});
+sconn=c;
+test();
+}).listen(0,common.mustCall(function(){
+tls.connect(this.address().port,{
+rejectUnauthorized: false
+},common.mustCall(function(){
+cconn=this;
+test();
+}));
+}));