test: refactor test-http-set-timeout-server

* Use `common.mustCall()` to track callback invocations * Remove console.log() statements unrelated to the test * Add blank line to conform with test-writing guide PR-URL: #13802 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>

Author: Trott

test/parallel/test-http-set-timeout-server.js

@@ -21,6 +21,7 @@
 
 'use strict';
 constcommon=require('../common');
+
 constassert=require('assert');
 consthttp=require('http');
 constnet=require('net');
@@ -30,16 +31,13 @@ const tests = [];
 functiontest(fn){
 if(!tests.length)
 process.nextTick(run);
-tests.push(fn);
+tests.push(common.mustCall(fn));
 }
 
 functionrun(){
 constfn=tests.shift();
 if(fn){
-console.log('# %s',fn.name);
 fn(run);
-}else{
-console.log('ok');
 }
 }
 
@@ -48,7 +46,7 @@ test(function serverTimeout(cb){
 // just do nothing, we should get a timeout event.
 });
 server.listen(common.mustCall(function(){
-http.get({port: server.address().port}).on('error',common.noop);
+http.get({port: server.address().port}).on('error',common.mustCall());
 }));
 consts=server.setTimeout(50,common.mustCall(function(socket){
 socket.destroy();
@@ -71,7 +69,7 @@ test(function serverRequestTimeout(cb){
 server.listen(common.mustCall(function(){
 constport=server.address().port;
 constreq=http.request({port: port,method: 'POST'});
-req.on('error',common.noop);
+req.on('error',common.mustCall());
 req.write('Hello');
 // req is in progress
 }));
@@ -89,7 +87,7 @@ test(function serverResponseTimeout(cb){
 });
 server.listen(common.mustCall(function(){
 constport=server.address().port;
-http.get({port: port}).on('error',common.noop);
+http.get({port: port}).on('error',common.mustCall());
 }));
 });
 
@@ -107,7 +105,7 @@ test(function serverRequestNotTimeoutAfterEnd(cb){
 });
 server.listen(common.mustCall(function(){
 constport=server.address().port;
-http.get({port: port}).on('error',common.noop);
+http.get({port: port}).on('error',common.mustCall());
 }));
 });