Skip to content

Commit f1f180d

Browse files
joyeecheungMylesBorins
authored andcommitted
util: skip type checks in internal getSystemErrorName
Backport-PR-URL: #18916 PR-URL: #18546 Reviewed-By: James M Snell <[email protected]>
1 parent 9cb3f10 commit f1f180d

File tree

2 files changed

+9
-6
lines changed

2 files changed

+9
-6
lines changed

‎lib/internal/util.js‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -208,11 +208,6 @@ function getConstructorOf(obj){
208208
}
209209

210210
functiongetSystemErrorName(err){
211-
if(typeoferr!=='number'||err>=0||!Number.isSafeInteger(err)){
212-
thrownewerrors.TypeError('ERR_INVALID_ARG_TYPE','err',
213-
'negative number');
214-
}
215-
216211
constentry=errmap.get(err);
217212
returnentry ? entry[0] : `Unknown system error ${err}`;
218213
}

‎lib/util.js‎

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ const{
5454
customInspectSymbol,
5555
deprecate,
5656
getConstructorOf,
57-
getSystemErrorName,
57+
getSystemErrorName: internalErrorName,
5858
isError,
5959
promisify,
6060
join,
@@ -1071,6 +1071,14 @@ function callbackify(original){
10711071
returncallbackified;
10721072
}
10731073

1074+
functiongetSystemErrorName(err){
1075+
if(typeoferr!=='number'||err>=0||!Number.isSafeInteger(err)){
1076+
thrownewerrors.TypeError('ERR_INVALID_ARG_TYPE','err',
1077+
'negative number');
1078+
}
1079+
returninternalErrorName(err);
1080+
}
1081+
10741082
// Keep the `exports =` so that various functions can still be monkeypatched
10751083
module.exports=exports={
10761084
_errnoException,

0 commit comments

Comments
(0)