test_runner: catch errors thrown within describe

PR-URL: #43729 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>

Author: MoLow

lib/internal/test_runner/test.js

@@ -360,6 +360,7 @@ class Test extends AsyncResource{
 if(this.endTime<this.startTime){
 this.endTime=hrtime();
 }
+this.startTime??=this.endTime;
 
 // The test has run, so recursively cancel any outstanding subtests and
 // mark this test as failed if any subtests failed.
@@ -457,7 +458,11 @@ class Suite extends Test{
 constructor(options){
 super(options);
 
-this.runInAsyncScope(this.fn);
+try{
+this.buildSuite=this.runInAsyncScope(this.fn);
+}catch(err){
+this.fail(newERR_TEST_FAILURE(err,kTestCodeFailure));
+}
 this.fn=()=>{};
 this.finished=true;// Forbid adding subtests to this suite
 }
@@ -467,9 +472,14 @@ class Suite extends Test{
 }
 
 asyncrun(){
+try{
+awaitthis.buildSuite;
+}catch(err){
+this.fail(newERR_TEST_FAILURE(err,kTestCodeFailure));
+}
 this.parent.activeSubtests++;
 this.startTime=hrtime();
-constsubtests=this.skipped ? [] : this.subtests;
+constsubtests=this.skipped||this.error? [] : this.subtests;
 awaitArrayPrototypeReduce(subtests,async(prev,subtest)=>{
 awaitprev;
 awaitsubtest.run();

test/message/test_runner_describe_it.js

@@ -45,6 +45,11 @@ it('async throw fail', async () =>{
 thrownewError('thrown from async throw fail');
 });
 
+it('async skip fail',async(t)=>{
+t.skip();
+thrownewError('thrown from async throw fail');
+});
+
 it('async assertion fail',async()=>{
 // Make sure the assert module is handled.
 assert.strictEqual(true,false);
@@ -301,3 +306,13 @@ describe('subtest sync throw fails', () =>{
 thrownewError('thrown from subtest sync throw fails at second');
 });
 });
+
+describe('describe sync throw fails',()=>{
+it('should not run',()=>{});
+thrownewError('thrown from describe');
+});
+
+describe('describe async throw fails',async()=>{
+it('should not run',()=>{});
+thrownewError('thrown from describe');
+});