test: shell out to rmdir first on Windows

cmd's `rmdir` is hardened to deal with Windows edge cases, like lingering processes, indexing, and AV checks. So we give it a try first. * Added `opts ={spawn = true }` to opt-out of spawning * test-pipeconnectwrap.js - spawning messes up async_hooks state PR-URL: #28035 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Sam Roberts <[email protected]>

Author: refack

test/async-hooks/test-pipeconnectwrap.js

@@ -5,11 +5,11 @@ const assert = require('assert');
 consttick=require('../common/tick');
 constinitHooks=require('./init-hooks');
 const{ checkInvocations }=require('./hook-checks');
-
+consttmpdir=require('../common/tmpdir');
 constnet=require('net');
 
-consttmpdir=require('../common/tmpdir');
-tmpdir.refresh();
+// Spawning messes up `async_hooks` state.
+tmpdir.refresh({spawn: false});
 
 consthooks=initHooks();
 hooks.enable();

test/common/README.md

@@ -852,7 +852,11 @@ The `tmpdir` module supports the use of a temporary directory for testing.
 
 The realpath of the testing temporary directory.
 
-### refresh()
+### refresh([opts])
+
+*`opts`[<Object>] (optional) Extra options.
+*`spawn`[<boolean>] (default: `true`) Indicates that `refresh` is allowed
+ to optionally spawn a subprocess.
 
 Deletes and recreates the testing temporary directory.
 

test/common/tmpdir.js

@@ -1,31 +1,65 @@
 /* eslint-disable node-core/require-common-first, node-core/required-modules */
 'use strict';
 
+const{ execSync }=require('child_process');
 constfs=require('fs');
 constpath=require('path');
+const{ debuglog }=require('util');
 
-functionrimrafSync(p){
-letst;
-try{
-st=fs.lstatSync(p);
-}catch(e){
-if(e.code==='ENOENT')
-return;
+constdebug=debuglog('test/tmpdir');
+
+functionrimrafSync(pathname,{ spawn =true}={}){
+constst=(()=>{
+try{
+returnfs.lstatSync(pathname);
+}catch(e){
+if(fs.existsSync(pathname))
+thrownewError(`Something wonky happened rimrafing ${pathname}`);
+debug(e);
+}
+})();
+
+// If (!st) then nothing to do.
+if(!st){
+return;
+}
+
+// On Windows first try to delegate rmdir to a shell.
+if(spawn&&process.platform==='win32'&&st.isDirectory()){
+try{
+// Try `rmdir` first.
+execSync(`rmdir /q /s ${pathname}`,{timout: 1000});
+}catch(e){
+// Attempt failed. Log and carry on.
+debug(e);
+}
 }
 
 try{
-if(st&&st.isDirectory())
-rmdirSync(p,null);
+if(st.isDirectory())
+rmdirSync(pathname,null);
 else
-fs.unlinkSync(p);
+fs.unlinkSync(pathname);
 }catch(e){
-if(e.code==='ENOENT')
-return;
-if(e.code==='EPERM')
-returnrmdirSync(p,e);
-if(e.code!=='EISDIR')
-throwe;
-rmdirSync(p,e);
+debug(e);
+switch(e.code){
+case'ENOENT':
+// It's not there anymore. Work is done. Exiting.
+return;
+
+case'EPERM':
+// This can happen, try again with `rmdirSync`.
+break;
+
+case'EISDIR':
+// Got 'EISDIR' even after testing `st.isDirectory()`...
+// Try again with `rmdirSync`.
+break;
+
+default:
+throwe;
+}
+rmdirSync(pathname,e);
 }
 }
 
@@ -62,8 +96,8 @@ if (process.env.TEST_THREAD_ID){
 
 consttmpPath=path.join(testRoot,tmpdirName);
 
-functionrefresh(){
-rimrafSync(this.path);
+functionrefresh(opts={}){
+rimrafSync(this.path,opts);
 fs.mkdirSync(this.path);
 }