process: make stdout and stderr emit 'close' on destroy

Fix: #26550 PR-URL: #26691 Fixes: https://github.com/falseFixes: #26550 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>

Author: mcollina

lib/internal/process/stdio.js

@@ -8,7 +8,26 @@ const{
 exports.setupProcessStdio=setupProcessStdio;
 exports.getMainThreadStdio=getMainThreadStdio;
 
-functiondummyDestroy(err,cb){cb(err);}
+functiondummyDestroy(err,cb){
+// SyncWriteStream does not use the stream
+// destroy mechanism for some legacy reason.
+// TODO(mcollina): remove when
+// https://github.com/nodejs/node/pull/26690 lands.
+if(typeofcb==='function'){
+cb(err);
+}
+
+// We need to emit 'close' anyway so that the closing
+// of the stream is observable. We just make sure we
+// are not going to do it twice.
+// The 'close' event is needed so that finished and
+// pipeline work correctly.
+if(!this._writableState.emitClose){
+process.nextTick(()=>{
+this.emit('close');
+});
+}
+}
 
 functiongetMainThreadStdio(){
 varstdin;

test/parallel/test-stdout-pipeline-destroy.js

@@ -0,0 +1,31 @@
+'use strict';
+
+constcommon=require('../common');
+const{ Transform, Readable, pipeline }=require('stream');
+constassert=require('assert');
+
+constreader=newReadable({
+read(size){this.push('foo');}
+});
+
+letcount=0;
+
+consterr=newError('this-error-gets-hidden');
+
+consttransform=newTransform({
+transform(chunk,enc,cb){
+if(count++>=5)
+this.emit('error',err);
+else
+cb(null,count.toString()+'\n');
+}
+});
+
+pipeline(
+reader,
+transform,
+process.stdout,
+common.mustCall((e)=>{
+assert.strictEqual(e,err);
+})
+);