doc: esm loader example with module.builtinModules

guybedford · gibfahn · commit f36ba1adca1d · 2017-12-20T22:35:14.000Z
PR-URL: #17385 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Timothy Gu <timothygu99@gmail.com>
diff --git a/doc/api/esm.md b/doc/api/esm.md
@@ -147,15 +147,13 @@ be written:
 import url from 'url';
 import path from 'path';
 import process from 'process';
+import Module from 'module';
 
-const builtins = new Set(
- Object.keys(process.binding('natives')).filter((str) =>
- /^(?!(?:internal|node|v8)\/)/.test(str))
-);
+const builtins = Module.builtinModules;
 const JS_EXTENSIONS = new Set(['.js', '.mjs']);
 
 export function resolve(specifier, parentModuleURL/*, defaultResolve */){
- if (builtins.has(specifier)){
+ if (builtins.includes(specifier)){
 return{
 url: specifier,
 format: 'builtin'

-Original file line number
+Diff line change
 importurlfrom'url';
 importpathfrom'path';
 importprocessfrom'process';
 +importModulefrom'module';
 -constbuiltins=newSet(
 -Object.keys(process.binding('natives')).filter((str) =>
 -/^(?!(?:internal|node|v8)\/)/.test(str))
 -);
 +constbuiltins=Module.builtinModules;
 constJS_EXTENSIONS=newSet(['.js', '.mjs']);
 exportfunctionresolve(specifier, parentModuleURL/*, defaultResolve */){
 -if (builtins.has(specifier)){
 +if (builtins.includes(specifier)){
 return{
  url: specifier,
  format:'builtin'