dns: use length for building TXT string

Rely on the length reported by C-Ares rather than `\0`-termination for creating the JS string for a dns TXT response. Fixes: #30688 PR-URL: #30690 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>

Author: addaleax

src/cares_wrap.cc

@@ -904,7 +904,8 @@ int ParseTxtReply(Environment* env,
 uint32_t i = 0, j;
 uint32_t offset = ret->Length();
 for (j = 0; current != nullptr; current = current->next){
- Local<String> txt = OneByteString(env->isolate(), current->txt);
+ Local<String> txt =
+OneByteString(env->isolate(), current->txt, current->length);
 
 // New record found - write out the current chunk
 if (current->record_start){

test/parallel/test-dns-resolveany.js

@@ -11,7 +11,7 @@ const answers = [
 {type: 'AAAA',address: '::42',ttl: 123},
 {type: 'MX',priority: 42,exchange: 'foobar.com',ttl: 124},
 {type: 'NS',value: 'foobar.org',ttl: 457},
-{type: 'TXT',entries: ['v=spf1 ~all','xyz']},
+{type: 'TXT',entries: ['v=spf1 ~all','xyz\0foo']},
 {type: 'PTR',value: 'baz.org',ttl: 987},
 {
 type: 'SOA',